From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 7 Feb 2018 08:43:13 +0800 From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, Christoph Hellwig , Mike Snitzer , linux-scsi@vger.kernel.org, Hannes Reinecke , Arun Easi , Omar Sandoval , "Martin K . Petersen" , James Bottomley , Christoph Hellwig , Don Brace , Kashyap Desai , Peter Rivera , Paolo Bonzini , Laurence Oberman Subject: Re: [PATCH V2 2/8] blk-mq: introduce BLK_MQ_F_GLOBAL_TAGS Message-ID: <20180207004311.GA13470@ming.t460p> References: <20180205152035.15016-1-ming.lei@redhat.com> <20180205152035.15016-3-ming.lei@redhat.com> <398c755a-ada6-1e60-9562-51b69476e55d@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <398c755a-ada6-1e60-9562-51b69476e55d@kernel.dk> List-ID: On Tue, Feb 06, 2018 at 04:18:20PM -0700, Jens Axboe wrote: > On 2/5/18 8:20 AM, Ming Lei wrote: ... > > GLOBAL implies that it's, strangely enough, global. That isn't really the > case. Why not call this BLK_MQ_F_HOST_TAGS or something like that? I'd > welcome better names, but global doesn't seem to be a great choice. > > BLK_MQ_F_SET_TAGS? Good point, I am fine with either BLK_MQ_F_HOST_TAGS or BLK_MQ_F_SET_TAGS, will update in V3. Thanks, Ming