From: Tejun Heo <tj@kernel.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Jens Axboe <axboe@kernel.dk>,
xuejiufei <jiufei.xue@linux.alibaba.com>,
Caspar Zhang <caspar@linux.alibaba.com>,
linux-block <linux-block@vger.kernel.org>,
cgroups@vger.kernel.org
Subject: Re: [PATCH v2] blk-throttle: fix race between blkcg_bio_issue_check and cgroup_rmdir
Date: Thu, 8 Feb 2018 07:23:07 -0800 [thread overview]
Message-ID: <20180208152307.GL695913@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <b590caed-1423-4776-966d-cd9e346a8ea1@linux.alibaba.com>
Hello, Joseph.
On Thu, Feb 08, 2018 at 10:29:43AM +0800, Joseph Qi wrote:
> So you mean checking css->refcnt to prevent the further use of
> blkg_get? I think it makes sense.
Yes.
> IMO, we should use css_tryget_online instead, and rightly after taking
Not really. An offline css still can have a vast amount of IO to
drain and write out.
> queue_lock. Because there may be more use of blkg_get in blk_throtl_bio
> in the futher. Actually it already has two now. One is in
> blk_throtl_assoc_bio, and the other is in throtl_qnode_add_bio.
> What do you think of this?
As long as we avoid making the bypass paths expensive, whatever makes
the code easier to read and maintain would be better. css ref ops are
extremely cheap anyway.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-02-08 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 8:40 [PATCH v2] blk-throttle: fix race between blkcg_bio_issue_check and cgroup_rmdir Joseph Qi
2018-02-07 21:38 ` Tejun Heo
2018-02-08 2:29 ` Joseph Qi
2018-02-08 15:23 ` Tejun Heo [this message]
2018-02-09 2:15 ` Joseph Qi
2018-02-12 17:11 ` Tejun Heo
2018-02-22 6:14 ` Joseph Qi
2018-02-22 15:18 ` Tejun Heo
2018-02-23 1:56 ` xuejiufei
2018-02-23 14:23 ` Tejun Heo
2018-02-24 1:45 ` Joseph Qi
2018-02-27 3:18 ` Joseph Qi
2018-02-27 18:33 ` Tejun Heo
2018-02-28 6:52 ` Joseph Qi
2018-03-04 20:23 ` Tejun Heo
2018-03-05 1:17 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208152307.GL695913@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=caspar@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=jiufei.xue@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox