From: Al Viro <viro@ZenIV.linux.org.uk>
To: John Pittman <jpittman@redhat.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer
Date: Thu, 15 Feb 2018 02:13:21 +0000 [thread overview]
Message-ID: <20180215021321.GB30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1518658622-5931-1-git-send-email-jpittman@redhat.com>
On Wed, Feb 14, 2018 at 08:37:02PM -0500, John Pittman wrote:
> In quite a few files throughout the block layer, the bare 'unsigned' is
> used rather than the preferred 'unsigned int'.
Preferred by whom?
> The issue was
What is that "issue" and why is it a problem in the first place?
> exposed by checkpatch.pl. Warnings encountered were:
Oh, good - so presumably it does have some explanations beyond "The Most Holy
checkpatch.pl Spake Unto Us"; could the esteemed sir share those with us?
next prev parent reply other threads:[~2018-02-15 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 1:37 [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer John Pittman
2018-02-15 2:03 ` Jens Axboe
2018-02-15 2:13 ` Al Viro [this message]
2018-02-15 2:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215021321.GB30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=jpittman@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox