linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, Hou Tao <houtao1@huawei.com>
Subject: Re: [PATCH 0/6 v2] block: Fix races in bdev - gendisk handling
Date: Mon, 26 Feb 2018 09:49:03 -0700	[thread overview]
Message-ID: <20180226164901.GA10232@kernel.dk> (raw)
In-Reply-To: <20180226164358.opwo7auv4neqvt6t@quack2.suse.cz>

On Mon, Feb 26 2018, Jan Kara wrote:
> On Mon 26-02-18 09:04:40, Jens Axboe wrote:
> > On 2/26/18 5:01 AM, Jan Kara wrote:
> > > Hello,
> > > 
> > > these patches fix races happening when devices are frequently destroyed and
> > > recreated in association of block device inode with corresponding gendisk.
> > > Generally when such race happen it results in use-after-free issues, block
> > > device page cache inconsistencies, or other problems. I have verified these
> > > patches fix use-after-free issues that could be reproduced by frequent creation
> > > and destruction of loop device. Hou Tao has verified that races reported by
> > > him in [1] related to gendisk-blkdev association were also fixed. Jens, can
> > > you please merge these patches? Thanks!
> > 
> > What are you thinking in terms of target? I'd like to get it into 4.16,
> > but I'd need to know if you are comfortable with that.
> 
> Yeah, 4.16 should be OK. The patches are quite conservative.

OK good, let's get it queued up. Thanks Jan.

-- 
Jens Axboe

      reply	other threads:[~2018-02-26 16:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 12:01 [PATCH 0/6 v2] block: Fix races in bdev - gendisk handling Jan Kara
2018-02-26 12:01 ` [PATCH 1/6] genhd: Fix leaked module reference for NVME devices Jan Kara
2018-02-27  0:09   ` Christoph Hellwig
2018-02-26 12:01 ` [PATCH 2/6] genhd: Rename get_disk() to get_disk_and_module() Jan Kara
2018-02-26 12:01 ` [PATCH 3/6] genhd: Add helper put_disk_and_module() Jan Kara
2018-02-26 12:01 ` [PATCH 4/6] genhd: Fix use after free in __blkdev_get() Jan Kara
2018-02-26 12:01 ` [PATCH 5/6] genhd: Fix BUG in blkdev_open() Jan Kara
2018-02-26 12:01 ` [PATCH 6/6] blockdev: Avoid two active bdev inodes for one device Jan Kara
2018-02-26 16:04 ` [PATCH 0/6 v2] block: Fix races in bdev - gendisk handling Jens Axboe
2018-02-26 16:43   ` Jan Kara
2018-02-26 16:49     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226164901.GA10232@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=houtao1@huawei.com \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).