From: Omar Sandoval <osandov@osandov.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH RFC] sbitmap: Use lock/unlock atomic bitops
Date: Tue, 27 Feb 2018 12:29:38 -0800 [thread overview]
Message-ID: <20180227202938.GA23026@vader.DHCP.thefacebook.com> (raw)
In-Reply-To: <20180227181404.GA24003@devbig577.frc2.facebook.com>
On Tue, Feb 27, 2018 at 10:14:04AM -0800, Tejun Heo wrote:
> Hello, Omar.
>
> On Mon, Feb 26, 2018 at 02:14:44PM -0800, Omar Sandoval wrote:
> > > wake_index = atomic_read(&sbq->wake_index);
> > > for (i = 0; i < SBQ_WAIT_QUEUES; i++) {
> > > struct sbq_wait_state *ws = &sbq->ws[wake_index];
> >
> > So I think we want a patch for the test_and_set_bit_lock() and
> > clear_bit_unlock(), but the rest should stay as-is.
>
> Yeah, that makes sense to me. Would you be interested in updating the
> patch?
Yup, I'll send it up. Thanks, Tejun!
prev parent reply other threads:[~2018-02-27 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 13:05 [PATCH RFC] sbitmap: Use lock/unlock atomic bitops Tejun Heo
2018-02-26 22:14 ` Omar Sandoval
2018-02-27 18:14 ` Tejun Heo
2018-02-27 20:29 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227202938.GA23026@vader.DHCP.thefacebook.com \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox