From: Christoph Hellwig <hch@infradead.org>
To: Coly Li <colyli@suse.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [RFC PATCH] bcache: enable big endian support for IBM s390x
Date: Thu, 15 Mar 2018 06:47:20 -0700 [thread overview]
Message-ID: <20180315134720.GA14209@infradead.org> (raw)
In-Reply-To: <20180315111500.24865-1-colyli@suse.de>
> +static void swap_cache_sb_from_cpu(struct cache_sb *sb,
> + struct cache_sb *out)
> +{
> + int i;
> +
> + out->offset = cpu_to_le64(sb->offset);
> + out->flags = cpu_to_le64(sb->flags);
> + out->seq = cpu_to_le64(sb->seq);
This looks completely bogus and sparse will complain loudly about it.
Please make sure you have proper endianess annotations in place.
next prev parent reply other threads:[~2018-03-15 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 11:15 [RFC PATCH] bcache: enable big endian support for IBM s390x Coly Li
2018-03-15 13:47 ` Christoph Hellwig [this message]
2018-03-15 15:45 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315134720.GA14209@infradead.org \
--to=hch@infradead.org \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).