From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Stefan Haberland <sth@linux.vnet.ibm.com>
Subject: Re: [PATCH 8/8] blk-mq: remove code for dealing with remapping queue
Date: Mon, 9 Apr 2018 12:09:13 +0200 [thread overview]
Message-ID: <20180409100913.GH11144@lst.de> (raw)
In-Reply-To: <20180408094814.28953-9-ming.lei@redhat.com>
On Sun, Apr 08, 2018 at 05:48:14PM +0800, Ming Lei wrote:
> Firstly, from commit 4b855ad37194 ("blk-mq: Create hctx for each present CPU),
> blk-mq doesn't remap queue any more after CPU topo is changed.
>
> Secondly, set->nr_hw_queues can't be bigger than nr_cpu_ids, and now we map
> all possible CPUs to hw queues, so at least one CPU is mapped to each hctx.
>
> So queue mapping has became static and fixed just like percpu variable, and
> we don't need to handle queue remapping any more.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-04-09 10:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 9:48 [PATCH 0/8] blk-mq: fix and improve queue mapping Ming Lei
2018-04-08 9:48 ` [PATCH 1/8] blk-mq: make sure that correct hctx->next_cpu is set Ming Lei
2018-04-09 10:04 ` Christoph Hellwig
2018-04-09 11:02 ` Sagi Grimberg
2018-04-08 9:48 ` [PATCH 2/8] blk-mq: don't keep offline CPUs mapped to hctx 0 Ming Lei
2018-04-09 10:04 ` Christoph Hellwig
2018-04-09 11:02 ` Sagi Grimberg
2018-04-08 9:48 ` [PATCH 3/8] blk-mq: avoid to write intermediate result to hctx->next_cpu Ming Lei
2018-04-09 10:05 ` Christoph Hellwig
2018-04-09 11:02 ` Sagi Grimberg
2018-04-08 9:48 ` [PATCH 4/8] blk-mq: introduce blk_mq_hw_queue_first_cpu() to figure out first cpu Ming Lei
2018-04-09 10:06 ` Christoph Hellwig
2018-04-09 11:02 ` Sagi Grimberg
2018-04-08 9:48 ` [PATCH 5/8] blk-mq: remove blk_mq_delay_queue() Ming Lei
2018-04-09 10:06 ` Christoph Hellwig
2018-04-09 11:03 ` Sagi Grimberg
2018-04-08 9:48 ` [PATCH 6/8] blk-mq: don't check queue mapped in __blk_mq_delay_run_hw_queue() Ming Lei
2018-04-09 10:07 ` Christoph Hellwig
2018-04-09 11:03 ` Sagi Grimberg
2018-04-08 9:48 ` [PATCH 7/8] blk-mq: reimplement blk_mq_hw_queue_mapped Ming Lei
2018-04-09 10:08 ` Christoph Hellwig
2018-04-09 11:03 ` Sagi Grimberg
2018-04-08 9:48 ` [PATCH 8/8] blk-mq: remove code for dealing with remapping queue Ming Lei
2018-04-09 10:09 ` Christoph Hellwig [this message]
2018-04-09 11:03 ` Sagi Grimberg
2018-04-09 10:13 ` [PATCH 0/8] blk-mq: fix and improve queue mapping Christian Borntraeger
2018-04-09 15:00 ` Jens Axboe
2018-04-09 15:48 ` Stefan Haberland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409100913.GH11144@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=borntraeger@de.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).