From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, Bart.VanAssche@wdc.com, willy@infradead.org,
linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/7] block: pass explicit gfp_t to get_request
Date: Tue, 10 Apr 2018 08:27:10 +0200 [thread overview]
Message-ID: <20180410082710.7a9ddeb9@pentland.suse.de> (raw)
In-Reply-To: <20180409153916.23901-5-hch@lst.de>
On Mon, 9 Apr 2018 17:39:13 +0200
Christoph Hellwig <hch@lst.de> wrote:
> blk_old_get_request already has it at hand, and in blk_queue_bio,
> which is the fast path, it is constant.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> block/blk-core.c | 14 +++++++-------
> drivers/scsi/scsi_error.c | 4 ----
> 2 files changed, 7 insertions(+), 11 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
next prev parent reply other threads:[~2018-04-10 6:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 15:39 [RFC] fix confusion around GFP_* flags and blk_get_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 1/7] scsi/osd: remove the gfp argument to osd_start_request Christoph Hellwig
2018-04-09 15:39 ` [PATCH 2/7] block: fix __get_request documentation Christoph Hellwig
2018-04-09 15:39 ` [PATCH 3/7] block: sanitize blk_get_request calling conventions Christoph Hellwig
2018-04-10 6:26 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 4/7] block: pass explicit gfp_t to get_request Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke [this message]
2018-04-09 15:39 ` [PATCH 5/7] block: use GFP_NOIO instead of __GFP_DIRECT_RECLAIM Christoph Hellwig
2018-04-10 6:27 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 6/7] block: consistently use GFP_NOIO instead of __GFP_NORECLAIM Christoph Hellwig
2018-04-09 16:03 ` Matthew Wilcox
2018-04-09 17:20 ` Christoph Hellwig
2018-04-10 6:28 ` Hannes Reinecke
2018-04-09 15:39 ` [PATCH 7/7] block: use GFP_KERNEL for allocations from blk_get_request Christoph Hellwig
2018-04-09 16:52 ` Matthew Wilcox
2018-04-09 17:21 ` Christoph Hellwig
2018-04-10 6:29 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410082710.7a9ddeb9@pentland.suse.de \
--to=hare@suse.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).