From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Alexandru Moise <00moses.alexander00@gmail.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] block: Ensure that a request queue is dissociated from the cgroup controller
Date: Thu, 12 Apr 2018 07:34:31 +0200 [thread overview]
Message-ID: <20180412053431.GB29881@lst.de> (raw)
In-Reply-To: <20180412015852.26014-1-bart.vanassche@wdc.com>
On Wed, Apr 11, 2018 at 07:58:52PM -0600, Bart Van Assche wrote:
> Several block drivers call alloc_disk() followed by put_disk() if
> something fails before device_add_disk() is called without calling
> blk_cleanup_queue(). Make sure that also for this scenario a request
> queue is dissociated from the cgroup controller. This patch avoids
> that loading the parport_pc, paride and pf drivers triggers the
> following kernel crash:
Can we move the cleanup to put_disk in general and not just for
this case? Having alloc/free routines pair up generally avoids
a lot of confusion.
next prev parent reply other threads:[~2018-04-12 5:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 1:58 [PATCH] block: Ensure that a request queue is dissociated from the cgroup controller Bart Van Assche
2018-04-12 4:20 ` Alexandru Moise
2018-04-12 4:32 ` Alexandru Moise
2018-04-12 4:22 ` Alexandru Moise
2018-04-12 5:34 ` Christoph Hellwig [this message]
2018-04-12 11:52 ` Bart Van Assche
2018-04-12 13:14 ` hch
2018-04-12 13:48 ` tj
2018-04-12 13:56 ` hch
2018-04-12 13:58 ` tj
2018-04-12 14:07 ` tj
2018-04-12 13:51 ` Tejun Heo
2018-04-12 14:09 ` Bart Van Assche
2018-04-12 15:37 ` Tejun Heo
2018-04-12 16:03 ` Bart Van Assche
2018-04-12 16:12 ` tj
2018-04-12 16:29 ` Bart Van Assche
2018-04-12 18:11 ` tj
2018-04-12 18:56 ` Bart Van Assche
2018-04-12 19:09 ` tj
2018-04-12 22:40 ` Bart Van Assche
2018-04-13 15:18 ` tj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412053431.GB29881@lst.de \
--to=hch@lst.de \
--cc=00moses.alexander00@gmail.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).