Re: [PATCH 2/3] scsi: read host_busy via scsi_host_busy()

Ming Lei
2018-04-28T08:17:51Z

On Fri, Apr 27, 2018 at 03:51:46PM +0000, Bart Van Assche wrote:
> On Fri, 2018-04-20 at 14:57 +0800, Ming Lei wrote:
> > show_host_busy(struct device *dev, struct device_attribute *attr, char *buf)
> > {
> > struct Scsi_Host *shost = class_to_shost(dev);
> > - return snprintf(buf, 20, "%d\n", atomic_read(&shost->host_busy));
> > + return snprintf(buf, 20, "%d\n", scsi_host_busy(shost));
> > }
> > static DEVICE_ATTR(host_busy, S_IRUGO, show_host_busy, NULL);
>
> The ", 20" part is cargo-cult programming. Since you have to touch this code,
> please either use "sprintf(buf, ...)" or use "scnprintf(buf, PAGE_SIZE, ...)".

This patch is only to replace atomic_read(&shost->host_busy) with
scsi_host_busy(shost) which returns 'int' too, so nothing related
with snprintf(buf, 20,..).

No mention the string with 20 length is enough to hold integer, so it
isn't needed too.

So I don't see any reason to do that in this patch.

Thanks,
Ming