From: Steven Rostedt <rostedt@goodmis.org>
To: Steffen Maier <maier@linux.ibm.com>
Cc: "Bean Huo (beanhuo)" <beanhuo@micron.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhad.com" <mingo@redhad.com>,
"Bart.VanAssche@sandisk.com" <Bart.VanAssche@sandisk.com>,
"rajatja@google.com" <rajatja@google.com>
Subject: Re: [RESEND PATCH v1 2/2] trace: events: block: Add tag in block trace events
Date: Mon, 23 Apr 2018 09:34:01 -0400 [thread overview]
Message-ID: <20180423093401.30839625@gandalf.local.home> (raw)
In-Reply-To: <f28ab517-9172-e585-718c-8a54adbfc3bc@linux.ibm.com>
On Mon, 23 Apr 2018 14:43:13 +0200
Steffen Maier <maier@linux.ibm.com> wrote:
> > - TP_printk("[%s] %d", __entry->comm, __entry->nr_rq)
> > + TP_printk("[%s] %d %s", __entry->comm, __entry->nr_rq,
> > + __entry->explicit ? "Sync" : "Async")
> > );
> >
> > /**
>
> This entire hunk does not seem related to this patch description.
> Also, I'm not sure trace-cmd and perf et al. could format it accordingly.
You mean the "?:" operation? trace-cmd and perf can handle it fine.
Just look at the trace event irq_handler_exit:
print fmt: "irq=%d ret=%s", REC->irq, REC->ret ? "handled" : "unhandled"
# trace-cmd record -e irq_handler_exit
# trace-cmd report
<idle>-0 [001] 856960.382767: irq_handler_exit: irq=29 ret=handled
<idle>-0 [001] 856961.745640: irq_handler_exit: irq=29 ret=handled
<idle>-0 [001] 856961.865762: irq_handler_exit: irq=29 ret=handled
-- Steve
prev parent reply other threads:[~2018-04-23 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 14:33 [RESEND PATCH v1 2/2] trace: events: block: Add tag in block trace events Bean Huo (beanhuo)
2018-04-16 15:29 ` Steven Rostedt
2018-04-16 20:49 ` Bart Van Assche
2018-04-23 12:43 ` Steffen Maier
2018-04-23 13:34 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423093401.30839625@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhad.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox