From: Keith Busch <keith.busch@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Omar Sandoval <osandov@osandov.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH blktests] Add surprise removal block test
Date: Tue, 24 Apr 2018 16:09:26 -0600 [thread overview]
Message-ID: <20180424220925.GF30375@localhost.localdomain> (raw)
In-Reply-To: <20180424220421.cwu5bat74633r4ga@linux-x5ow.site>
On Tue, Apr 24, 2018 at 04:04:22PM -0600, Johannes Thumshirn wrote:
> On Tue, Apr 24, 2018 at 03:41:46PM -0600, Keith Busch wrote:
>
> [...]
>
> > +DESCRIPTION="break PCI link while doing I/O"
> > +TIMED=1
>
> I _think_ we can set QUICK=1 here, Omar?
>
> > +
> > +requires() {
> > + _have_fio
> > +}
>
> You're using setpci below, so please add it to requires,
> i.e. _have_fio && _have_program setpci
>
> > +
> > +device_requires() {
> > + _test_dev_is_pci
> > + _test_hotplug_slot
> > +}
>
> I think this sould be _test_dev_is_pci && _test_hotplug_slot
Sounds good. Thanks for the feedback!
next prev parent reply other threads:[~2018-04-24 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 21:41 [PATCH blktests] Add surprise removal block test Keith Busch
2018-04-24 22:04 ` Johannes Thumshirn
2018-04-24 22:09 ` Keith Busch [this message]
2018-04-25 15:56 ` Omar Sandoval
2018-04-25 17:49 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424220925.GF30375@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox