Re: [PATCH 2/2] xfs: add 'discard_sync' mount flag

Martin K. Petersen
2018-05-02T02:54:15Z

Jens,

> diff --git a/block/blk-wbt.h b/block/blk-wbt.h
> index a232c98fbf4d..aec5bc82d580 100644
> --- a/block/blk-wbt.h
> +++ b/block/blk-wbt.h
> @@ -14,12 +14,17 @@ enum wbt_flags {
> WBT_TRACKED = 1, /* write, tracked for throttling */
> WBT_READ = 2, /* read */
> WBT_KSWAPD = 4, /* write, from kswapd */
> + WBT_TRIM = 8,

The term TRIM does not apply to NVMe, nor SCSI. Please call it
WBT_DISCARD.

--
Martin K. Petersen Oracle Linux Engineering