From: Benlong Zhang <zhangbenlong@didichuxing.com>
To: Tejun Heo <tj@kernel.org>
Cc: <axboe@kernel.dk>, <shli@kernel.org>, <david@fromorbit.com>,
<bfoster@redhat.com>, <linux-block@vger.kernel.org>,
Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] A tentative patch to bypass REQ_META in blk throttle
Date: Wed, 2 May 2018 10:20:20 +0800 [thread overview]
Message-ID: <20180502022004.GA3831@localhost> (raw)
In-Reply-To: <20180426190118.GP1911913@devbig577.frc2.facebook.com>
Hi Tejun,
On Thu, Apr 26, 2018 at 12:01:18PM -0700, Tejun Heo wrote:
> Hello,
>
> On Fri, Apr 20, 2018 at 06:06:01PM +0800, Benlong Zhang wrote:
> > One problem with cgwb is how fs should treat metadata bios.
> > For example in xfs, the log might be partially stuck in one
> > group, leaving threads in other groups waiting for too long.
> > Please refer to the linux-xfs discussion:
> > "[PATCH V2] xfs: implement cgroup writeback support"
> >
> > One approach is to correctly tag bio->bi_css from within the
> > filesystems (for xfs log should be blkcg_root), and the other
> > is to skip them, but relies on REQ_META being set.
> >
> > It works with xfs on a cgwb porting implementation to 3.10.0.
> > But really not sure about other filesystems...
>
> Yeah, Josef (cc'd) is working on a similar approach but in a more
> generic way.
Good to know and looking forward to the code.
Thank you for your reply!
Benlong
>
> Thanks.
>
> --
> tejun
prev parent reply other threads:[~2018-05-02 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 10:06 [PATCH] A tentative patch to bypass REQ_META in blk throttle Benlong Zhang
2018-04-26 19:01 ` Tejun Heo
2018-04-27 12:20 ` Brian Foster
2018-04-27 12:34 ` Tejun Heo
2018-05-02 2:20 ` Benlong Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502022004.GA3831@localhost \
--to=zhangbenlong@didichuxing.com \
--cc=axboe@kernel.dk \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=shli@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).