Re: [PATCH 1/2] nvme: pci: simplify timeout handling

Keith Busch
2018-05-10T22:43:57Z

On Fri, May 11, 2018 at 06:03:59AM +0800, Ming Lei wrote:
> Sorry, forget to mention, it isn't enough to simply sync timeout inside reset().
>
> Another tricky thing is about freeze & unfreeze, now freeze is done in
> nvme_dev_disable(), and unfreeze is done in nvme_reset_work. That means
> we have to make sure both are paired, otherwise queues may be kept as
> freeze for ever.
>
> This issue is covered by my V4 & V5 too.

That it isn't an issue in my patch either.