From: Christoph Hellwig <hch@lst.de>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: Bart Van Assche <bart.vanassche@wdc.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Tejun Heo <tj@kernel.org>, Ming Lei <ming.lei@redhat.com>,
Sebastian Ott <sebott@linux.ibm.com>,
Sagi Grimberg <sagi@grimberg.me>,
Israel Rukshin <israelr@mellanox.com>,
Max Gurtovoy <maxg@mellanox.com>
Subject: Re: [PATCH] blk-mq: Rework blk-mq timeout handling again
Date: Fri, 11 May 2018 14:35:19 +0200 [thread overview]
Message-ID: <20180511123519.GA14123@lst.de> (raw)
In-Reply-To: <73f77c62-25ca-0915-6f5b-452d60258f05@oracle.com>
> It should be due to union blk_deadline_and_state.
> +union blk_deadline_and_state {
> + struct {
> + uint32_t generation:30;
> + uint32_t state:2;
> + uint32_t deadline;
> + };
> + unsigned long legacy_deadline;
> + uint64_t das;
> +};
Yikes. Or we just move it into a separate field. This patch already
shrinks struct request a lot, so I'd rather do that to keep it simple.
next prev parent reply other threads:[~2018-05-11 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 17:56 [PATCH] blk-mq: Rework blk-mq timeout handling again Bart Van Assche
2018-05-11 12:06 ` jianchao.wang
2018-05-11 12:35 ` Christoph Hellwig [this message]
2018-05-11 15:29 ` Bart Van Assche
2018-05-14 1:37 ` jianchao.wang
2018-05-14 4:03 ` Bart Van Assche
2018-05-14 5:15 ` jianchao.wang
2018-05-14 18:44 ` Bart Van Assche
2018-05-11 15:26 ` Bart Van Assche
2018-05-14 1:48 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511123519.GA14123@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=israelr@mellanox.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=sebott@linux.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox