From: David Miller <davem@davemloft.net>
To: axboe@kernel.dk
Cc: hch@lst.de, linux-block@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH] jsflash: fix compilation
Date: Tue, 15 May 2018 15:51:18 -0400 (EDT) [thread overview]
Message-ID: <20180515.155118.1408865987817486838.davem@davemloft.net> (raw)
In-Reply-To: <0ec7d5d1-cd5f-b415-b866-1b3daa9fa840@kernel.dk>
From: Jens Axboe <axboe@kernel.dk>
Date: Tue, 15 May 2018 13:00:36 -0600
> On 5/15/18 12:58 PM, David Miller wrote:
>> From: Jens Axboe <axboe@kernel.dk>
>> Date: Tue, 15 May 2018 12:51:20 -0600
>>
>>> On 5/15/18 12:32 PM, Christoph Hellwig wrote:
>>>> No bio in this whole function, use req->bio instead.
>>>
>>> Applied.
>>>
>>>> Looks like no one except for Guenters build bot cared. I wonder if we
>>>> should just get rid of the driver given that it doesn't look in a good
>>>> shape at all based on his build logs even with the fix..
>>>
>>> Needs input from the folks that actually might use it. The driver looks
>>> abandoned, it's only getting updates through API changes etc.
>>
>> I don't think anyone is using it.
>
> Are you fine with removing it then?
Yes, I am:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2018-05-15 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 18:32 [PATCH] jsflash: fix compilation Christoph Hellwig
2018-05-15 18:51 ` Jens Axboe
2018-05-15 18:58 ` David Miller
2018-05-15 19:00 ` Jens Axboe
2018-05-15 19:51 ` David Miller [this message]
2018-05-15 19:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515.155118.1408865987817486838.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).