From: Keith Busch <keith.busch@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bart.vanassche@wdc.com>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Tejun Heo <tj@kernel.org>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Ming Lei <ming.lei@redhat.com>,
Sebastian Ott <sebott@linux.ibm.com>,
Sagi Grimberg <sagi@grimberg.me>,
Israel Rukshin <israelr@mellanox.com>,
Max Gurtovoy <maxg@mellanox.com>
Subject: Re: [PATCH v13] blk-mq: Rework blk-mq timeout handling again
Date: Tue, 22 May 2018 14:26:58 -0600 [thread overview]
Message-ID: <20180522202657.GA8961@localhost.localdomain> (raw)
In-Reply-To: <e414a6f8-79a9-0faa-e186-beb3b528acd5@kernel.dk>
On Tue, May 22, 2018 at 01:38:06PM -0600, Jens Axboe wrote:
> I guess it would be cleaner to actually do the transition, in
> blk_mq_rq_timed_out():
>
> case BLK_EH_HANDLED:
> if (blk_mq_change_rq_state(req, MQ_RQ_TIMED_OUT,
> MQ_RQ_COMPLETE))
> __blk_mq_complete_request(req);
> break;
>
> This works for me.
Works for me as well on manual fault injection tests.
I think this change above goes back to Christoph's point earlier on usage
of BLK_EH_HANDLED. Is the driver supposed to return BLK_EH_NOT_HANDLED
when the driver actually knows the request has been completed before
returning the status?
next prev parent reply other threads:[~2018-05-22 20:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 16:25 [PATCH v13] blk-mq: Rework blk-mq timeout handling again Bart Van Assche
2018-05-22 16:44 ` Jens Axboe
2018-05-22 17:17 ` Jens Axboe
2018-05-22 18:47 ` Jens Axboe
2018-05-22 19:03 ` Jens Axboe
2018-05-22 19:38 ` Jens Axboe
2018-05-22 20:26 ` Keith Busch [this message]
2018-05-22 20:29 ` Jens Axboe
2018-05-22 21:02 ` Christoph Hellwig
2018-05-22 21:02 ` Jens Axboe
2018-05-22 20:33 ` Bart Van Assche
2018-05-22 20:38 ` Jens Axboe
2018-05-22 20:44 ` Bart Van Assche
2018-05-22 21:03 ` Jens Axboe
2018-05-23 2:35 ` Ming Lei
2018-05-22 20:33 ` Keith Busch
2018-05-22 20:36 ` Bart Van Assche
2018-05-22 20:40 ` Keith Busch
2018-05-22 20:44 ` Keith Busch
2018-05-22 20:47 ` Bart Van Assche
2018-05-23 14:02 ` Keith Busch
2018-05-23 14:08 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522202657.GA8961@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=sebott@linux.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).