From: Keith Busch <keith.busch@intel.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"israelr@mellanox.com" <israelr@mellanox.com>,
"sagi@grimberg.me" <sagi@grimberg.me>, "hch@lst.de" <hch@lst.de>,
"sebott@linux.ibm.com" <sebott@linux.ibm.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>,
"maxg@mellanox.com" <maxg@mellanox.com>,
"tj@kernel.org" <tj@kernel.org>
Subject: Re: [PATCH v13] blk-mq: Rework blk-mq timeout handling again
Date: Tue, 22 May 2018 14:40:15 -0600 [thread overview]
Message-ID: <20180522204015.GA9005@localhost.localdomain> (raw)
In-Reply-To: <632c16e5c06edb13c93d61f9164584da470d8a24.camel@wdc.com>
On Tue, May 22, 2018 at 08:36:27PM +0000, Bart Van Assche wrote:
> Have you noticed that if blk_mq_complete_request() encounters a request with
> state MQ_RQ_TIMED_OUT that it doesn't call __blk_mq_complete_request()? I think
> the code in blk_mq_complete_request() together with the above code guarantees
> that __blk_mq_complete_request() is only called once per request generation.
Right, my mistake. I noticed that when I saw your reply on the EH_HANDLED
case, so looks fine.
next prev parent reply other threads:[~2018-05-22 20:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 16:25 [PATCH v13] blk-mq: Rework blk-mq timeout handling again Bart Van Assche
2018-05-22 16:44 ` Jens Axboe
2018-05-22 17:17 ` Jens Axboe
2018-05-22 18:47 ` Jens Axboe
2018-05-22 19:03 ` Jens Axboe
2018-05-22 19:38 ` Jens Axboe
2018-05-22 20:26 ` Keith Busch
2018-05-22 20:29 ` Jens Axboe
2018-05-22 21:02 ` Christoph Hellwig
2018-05-22 21:02 ` Jens Axboe
2018-05-22 20:33 ` Bart Van Assche
2018-05-22 20:38 ` Jens Axboe
2018-05-22 20:44 ` Bart Van Assche
2018-05-22 21:03 ` Jens Axboe
2018-05-23 2:35 ` Ming Lei
2018-05-22 20:33 ` Keith Busch
2018-05-22 20:36 ` Bart Van Assche
2018-05-22 20:40 ` Keith Busch [this message]
2018-05-22 20:44 ` Keith Busch
2018-05-22 20:47 ` Bart Van Assche
2018-05-23 14:02 ` Keith Busch
2018-05-23 14:08 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522204015.GA9005@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=sebott@linux.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).