From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V5 28/33] block: kill bio_for_each_page_all()
Date: Thu, 24 May 2018 17:01:33 +0800 [thread overview]
Message-ID: <20180524090139.2150-29-ming.lei@redhat.com> (raw)
In-Reply-To: <20180524090139.2150-1-ming.lei@redhat.com>
No one uses it any more, so kill it and we can reuse this helper
name.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
include/linux/bio.h | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 5ae2bc876295..c5e692d43f23 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -159,8 +159,10 @@ static inline void *bio_data(struct bio *bio)
/*
* drivers should _never_ use the all version - the bio may have been split
* before it got to the driver and the driver won't own all of it
+ *
+ * This helper iterates bio segment by segment.
*/
-#define bio_for_each_page_all(bvl, bio, i) \
+#define bio_for_each_segment_all(bvl, bio, i) \
for (i = 0, bvl = (bio)->bi_io_vec; i < (bio)->bi_vcnt; i++, bvl++)
static inline void __bio_advance_iter(struct bio *bio, struct bvec_iter *iter,
@@ -225,9 +227,6 @@ static inline bool bio_rewind_iter(struct bio *bio, struct bvec_iter *iter,
#define bio_for_each_segment(bvl, bio, iter) \
__bio_for_each_segment(bvl, bio, iter, (bio)->bi_iter)
-#define bio_for_each_segment_all(bvl, bio, i) \
- bio_for_each_page_all((bvl), (bio), (i))
-
/*
* This helper returns singlepage bvec to caller, and the sp bvec is
* generated in-flight from multipage bvec stored in bvec table. So we
--
2.9.5
next prev parent reply other threads:[~2018-05-24 9:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 9:01 [PATCH V5 00/33] block: support multipage bvec Ming Lei
2018-05-24 9:01 ` [PATCH V5 01/33] block: rename bio_for_each_segment* with bio_for_each_page* Ming Lei
2018-05-24 9:01 ` [PATCH V5 02/33] block: rename rq_for_each_segment as rq_for_each_page Ming Lei
2018-05-24 9:01 ` [PATCH V5 03/33] block: rename bio_segments() with bio_pages() Ming Lei
2018-05-24 9:01 ` [PATCH V5 04/33] block: introduce multipage page bvec helpers Ming Lei
2018-05-24 9:01 ` [PATCH V5 05/33] block: introduce bio_for_each_segment() Ming Lei
2018-05-24 9:01 ` [PATCH V5 06/33] block: use bio_for_each_segment() to compute segments count Ming Lei
2018-05-24 9:01 ` [PATCH V5 07/33] block: use bio_for_each_segment() to map sg Ming Lei
2018-05-24 9:01 ` [PATCH V5 08/33] block: introduce segment_last_page() Ming Lei
2018-05-24 9:01 ` [PATCH V5 09/33] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-05-24 9:01 ` [PATCH V5 10/33] btrfs: use segment_last_page to get bio's last page Ming Lei
2018-05-24 21:44 ` David Sterba
2018-05-25 0:07 ` Ming Lei
2018-05-24 9:01 ` [PATCH V5 11/33] block: implement bio_pages_all() via bio_for_each_page_all() Ming Lei
2018-05-24 9:01 ` [PATCH V5 12/33] block: introduce bio_segments() Ming Lei
2018-05-24 9:01 ` [PATCH V5 13/33] block: introduce rq_for_each_segment() Ming Lei
2018-05-24 9:01 ` [PATCH V5 14/33] block: loop: pass segments to iov_iter Ming Lei
2018-05-24 9:01 ` [PATCH V5 15/33] block: introduce bio_clone_seg_bioset() Ming Lei
2018-05-24 9:01 ` [PATCH V5 16/33] dm: clone bio via bio_clone_seg_bioset Ming Lei
2018-05-24 9:01 ` [PATCH V5 17/33] block: bio: introduce bio_for_each_page_all2 and bio_for_each_segment_all Ming Lei
2018-05-24 9:01 ` [PATCH V5 18/33] block: deal with dirtying pages for multipage bvec Ming Lei
2018-05-24 9:01 ` [PATCH V5 19/33] block: convert to bio_for_each_page_all2() Ming Lei
2018-05-24 9:01 ` [PATCH V5 20/33] md/dm/bcache: conver to bio_for_each_page_all2 and bio_for_each_segment Ming Lei
2018-05-24 9:01 ` [PATCH V5 21/33] fs: conver to bio_for_each_page_all2 Ming Lei
2018-05-24 9:01 ` [PATCH V5 22/33] btrfs: " Ming Lei
2018-05-24 9:01 ` [PATCH V5 23/33] ext4: " Ming Lei
2018-05-24 9:01 ` [PATCH V5 24/33] f2fs: " Ming Lei
2018-05-24 9:01 ` [PATCH V5 25/33] xfs: " Ming Lei
2018-05-24 9:01 ` [PATCH V5 26/33] exofs: " Ming Lei
2018-05-24 9:01 ` [PATCH V5 27/33] gfs2: " Ming Lei
2018-05-24 9:01 ` Ming Lei [this message]
2018-05-24 9:01 ` [PATCH V5 29/33] block: rename bio_for_each_page_all2 as bio_for_each_page_all Ming Lei
2018-05-24 9:01 ` [PATCH V5 30/33] block: enable multipage bvecs Ming Lei
2018-05-24 9:01 ` [PATCH V5 31/33] block: bio: pass segments to bio if bio_add_page() is bypassed Ming Lei
2018-05-24 9:01 ` [PATCH V5 32/33] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-05-24 9:01 ` [PATCH V5 33/33] block: document usage of bio iterator helpers Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524090139.2150-29-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox