From: Christoph Hellwig <hch@lst.de>
To: linux-nvme@lists.infradead.org
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
linux-block@vger.kernel.org
Subject: [PATCH 14/14] nvme: limit warnings from nvme_identify_ns
Date: Sat, 26 May 2018 12:27:35 +0200 [thread overview]
Message-ID: <20180526102735.31404-15-hch@lst.de> (raw)
In-Reply-To: <20180526102735.31404-1-hch@lst.de>
When rescanning namespaces after an AEN we will issue Identify Namespace
comands to namespaces that have gone away, so don't warn for this specific
case.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/host/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 1ae77428a1a5..7ad3cfc9d4e1 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -984,7 +984,9 @@ static struct nvme_id_ns *nvme_identify_ns(struct nvme_ctrl *ctrl,
error = nvme_submit_sync_cmd(ctrl->admin_q, &c, id, sizeof(*id));
if (error) {
- dev_warn(ctrl->device, "Identify namespace failed\n");
+ /* don't warn on a namespace that has gone away */
+ if (error < 0 || ((error & ~NVME_SC_DNR) != NVME_SC_INVALID_NS))
+ dev_warn(ctrl->device, "Identify namespace failed\n");
kfree(id);
return NULL;
}
--
2.17.0
next prev parent reply other threads:[~2018-05-26 10:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 10:27 nvme/nvmet AEN and log page fixups Christoph Hellwig
2018-05-26 10:27 ` [PATCH 01/14] block: unexport check_disk_size_change Christoph Hellwig
2018-05-28 6:33 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 02/14] block: don't print a message when the device went away Christoph Hellwig
2018-05-28 6:34 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 03/14] nvme.h: untangle AEN notice definitions Christoph Hellwig
2018-05-28 6:35 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 04/14] nvme.h: add the changed namespace list log Christoph Hellwig
2018-05-28 6:35 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 05/14] nvme.h: add AER configuration symbols Christoph Hellwig
2018-05-28 6:35 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 06/14] nvmet: add a new nvmet_zero_sgl helper Christoph Hellwig
2018-05-28 6:36 ` Johannes Thumshirn
2018-05-29 8:13 ` Christoph Hellwig
2018-05-26 10:27 ` [PATCH 07/14] nvmet: split log page implementation Christoph Hellwig
2018-05-28 6:38 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 08/14] nvmet: implement the changed namespaces log Christoph Hellwig
2018-05-28 6:53 ` Johannes Thumshirn
2018-05-29 8:17 ` Christoph Hellwig
2018-05-29 8:16 ` Johannes Thumshirn
2018-05-29 8:24 ` Christoph Hellwig
2018-05-29 16:59 ` Verkamp, Daniel
2018-05-29 17:24 ` Christoph Hellwig
2018-05-29 20:44 ` Daniel Verkamp
2018-05-26 10:27 ` [PATCH 09/14] nvmet: Add AEN configuration support Christoph Hellwig
2018-05-28 6:54 ` Johannes Thumshirn
2018-05-29 17:15 ` Verkamp, Daniel
2018-05-29 17:29 ` Christoph Hellwig
2018-05-29 17:35 ` Verkamp, Daniel
2018-05-29 17:45 ` Christoph Hellwig
2018-05-26 10:27 ` [PATCH 10/14] nvmet: mask pending AERs Christoph Hellwig
2018-05-28 6:56 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 11/14] nvme: submit AEN event configuration on startup Christoph Hellwig
2018-05-28 6:56 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 12/14] nvme: mark nvme_queue_scan static Christoph Hellwig
2018-05-28 6:57 ` Johannes Thumshirn
2018-05-26 10:27 ` [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs Christoph Hellwig
2018-05-26 12:05 ` Popuri, Sriram
2018-05-26 12:21 ` Christoph Hellwig
2018-05-26 13:02 ` Knight, Frederick
2018-05-28 6:59 ` Johannes Thumshirn
2018-06-04 19:59 ` Keith Busch
2018-06-05 4:47 ` Christoph Hellwig
2018-06-05 14:37 ` Keith Busch
2018-05-26 10:27 ` Christoph Hellwig [this message]
2018-05-28 7:00 ` [PATCH 14/14] nvme: limit warnings from nvme_identify_ns Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180526102735.31404-15-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).