* [PATCH] block/020: not pass shared_tags to null_blk
@ 2018-05-30 5:10 Ming Lei
2018-05-30 5:47 ` Omar Sandoval
0 siblings, 1 reply; 2+ messages in thread
From: Ming Lei @ 2018-05-30 5:10 UTC (permalink / raw)
To: Omar Sandoval; +Cc: Jens Axboe, linux-block, Ming Lei
The issue isn't related with shared tag, and it can be
triggered in case 'shared_tags' is set as 0.
Remove this so that this test can be run in older kernel, and
avoid to cause misunderstanding.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
tests/block/020 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/block/020 b/tests/block/020
index 40a8151c90a8..36140136369b 100755
--- a/tests/block/020
+++ b/tests/block/020
@@ -31,7 +31,7 @@ test() {
modprobe -r null_blk
modprobe null_blk queue_mode=2 irqmode=2 completion_nsec=2000000 \
- shared_tags=1 submit_queues=4 hw_queue_depth=1
+ submit_queues=4 hw_queue_depth=1
local scheds
# shellcheck disable=SC2207
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block/020: not pass shared_tags to null_blk
2018-05-30 5:10 [PATCH] block/020: not pass shared_tags to null_blk Ming Lei
@ 2018-05-30 5:47 ` Omar Sandoval
0 siblings, 0 replies; 2+ messages in thread
From: Omar Sandoval @ 2018-05-30 5:47 UTC (permalink / raw)
To: Ming Lei; +Cc: Omar Sandoval, Jens Axboe, linux-block
On Wed, May 30, 2018 at 01:10:38PM +0800, Ming Lei wrote:
> The issue isn't related with shared tag, and it can be
> triggered in case 'shared_tags' is set as 0.
>
> Remove this so that this test can be run in older kernel, and
> avoid to cause misunderstanding.
Thanks, Ming, applied.
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> tests/block/020 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/block/020 b/tests/block/020
> index 40a8151c90a8..36140136369b 100755
> --- a/tests/block/020
> +++ b/tests/block/020
> @@ -31,7 +31,7 @@ test() {
>
> modprobe -r null_blk
> modprobe null_blk queue_mode=2 irqmode=2 completion_nsec=2000000 \
> - shared_tags=1 submit_queues=4 hw_queue_depth=1
> + submit_queues=4 hw_queue_depth=1
>
> local scheds
> # shellcheck disable=SC2207
> --
> 2.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-30 5:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-30 5:10 [PATCH] block/020: not pass shared_tags to null_blk Ming Lei
2018-05-30 5:47 ` Omar Sandoval
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).