From: Mike Snitzer <snitzer@redhat.com>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk, hch@infradead.org, colyli@suse.de,
darrick.wong@oracle.com, clm@fb.com, bacik@fb.com,
linux-xfs@vger.kernel.org, drbd-dev@lists.linbit.com,
linux-btrfs@vger.kernel.org, linux-raid@vger.kernel.org,
neilb@suse.com
Subject: Re: [PATCH 07/12] dm: convert to bioset_init()/mempool_init()
Date: Wed, 30 May 2018 15:27:48 -0400 [thread overview]
Message-ID: <20180530192747.GA6568@redhat.com> (raw)
In-Reply-To: <20180520222558.7053-8-kent.overstreet@gmail.com>
On Sun, May 20 2018 at 6:25pm -0400,
Kent Overstreet <kent.overstreet@gmail.com> wrote:
> Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
> ---
> drivers/md/dm-bio-prison-v1.c | 13 ++++---
> drivers/md/dm-bio-prison-v2.c | 13 ++++---
> drivers/md/dm-cache-target.c | 25 ++++++-------
> drivers/md/dm-core.h | 4 +-
> drivers/md/dm-crypt.c | 60 ++++++++++++++----------------
> drivers/md/dm-integrity.c | 15 ++++----
> drivers/md/dm-io.c | 29 ++++++++-------
> drivers/md/dm-kcopyd.c | 22 ++++++-----
> drivers/md/dm-log-userspace-base.c | 19 +++++-----
> drivers/md/dm-region-hash.c | 23 ++++++------
> drivers/md/dm-rq.c | 2 +-
> drivers/md/dm-snap.c | 17 ++++-----
> drivers/md/dm-thin.c | 32 ++++++++--------
> drivers/md/dm-verity-fec.c | 55 +++++++++++++--------------
> drivers/md/dm-verity-fec.h | 8 ++--
> drivers/md/dm-zoned-target.c | 13 +++----
> drivers/md/dm.c | 53 ++++++++++++--------------
> 17 files changed, 197 insertions(+), 206 deletions(-)
In general I think each of these driver patches in the series needs a
one-line summary in the description, e.g.:
Embed bioset and mempool_t to avoid pointer indirection in the fast IO path.
But that aside, on a code level, I had to double check bioset_exit() is
safe to call even if bioset_init() failed. AFter confirming it is (and
double checking by chatting with Kent) I like how the code is simpler
(not having to check if the bioset is set before calling it).
Nice job Kent, like you said: mostly mechnical. But even the changes
that weren't purely mechnical (e.g. passing r to ERR_PTR, rather than
using old hardcode) were fixed up nicely.
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2018-05-30 19:27 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-20 22:25 [PATCH 00/13] convert block layer to bioset_init()/mempool_init() Kent Overstreet
2018-05-20 22:25 ` [PATCH 01/12] block: convert bounce, q->bio_split " Kent Overstreet
2018-05-22 10:08 ` Christoph Hellwig
2018-05-20 22:25 ` [PATCH 02/12] drbd: convert " Kent Overstreet
2018-05-20 22:25 ` [PATCH 03/12] pktcdvd: " Kent Overstreet
2018-05-20 22:25 ` [PATCH 04/12] lightnvm: " Kent Overstreet
2018-05-22 10:10 ` Javier Gonzalez
2018-05-20 22:25 ` [PATCH 05/12] bcache: " Kent Overstreet
2018-05-21 3:58 ` Coly Li
2018-05-20 22:25 ` [PATCH 06/12] md: " Kent Overstreet
2018-06-01 10:51 ` Arnd Bergmann
2018-05-20 22:25 ` [PATCH 07/12] dm: " Kent Overstreet
2018-05-30 19:27 ` Mike Snitzer [this message]
2018-05-20 22:25 ` [PATCH 08/12] target: " Kent Overstreet
2018-05-22 10:09 ` Christoph Hellwig
2018-05-20 22:25 ` [PATCH 09/12] fs: convert block_dev.c to bioset_init() Kent Overstreet
2018-05-22 10:09 ` Christoph Hellwig
2018-05-20 22:25 ` [PATCH 10/12] btrfs: convert to bioset_init()/mempool_init() Kent Overstreet
2018-05-30 21:30 ` Chris Mason
2018-05-20 22:25 ` [PATCH 11/12] xfs: " Kent Overstreet
2018-05-21 18:39 ` Darrick J. Wong
2018-05-22 10:10 ` Christoph Hellwig
2018-05-20 22:25 ` [PATCH 12/12] block: Drop bioset_create() Kent Overstreet
2018-05-22 10:10 ` Christoph Hellwig
2018-05-20 23:08 ` [PATCH 00/13] convert block layer to bioset_init()/mempool_init() NeilBrown
2018-05-20 23:11 ` Kent Overstreet
2018-05-21 14:03 ` Mike Snitzer
2018-05-21 14:19 ` Jens Axboe
2018-05-21 14:31 ` Mike Snitzer
2018-05-21 14:36 ` Jens Axboe
2018-05-21 14:47 ` Mike Snitzer
2018-05-21 14:52 ` Jens Axboe
2018-05-21 15:04 ` Mike Snitzer
2018-05-21 15:09 ` Jens Axboe
2018-05-21 15:18 ` Mike Snitzer
2018-05-21 15:36 ` Jens Axboe
2018-05-21 16:09 ` Mike Snitzer
2018-05-21 16:20 ` Jens Axboe
2018-05-30 13:36 ` Mike Snitzer
2018-05-30 18:55 ` Jens Axboe
2018-05-30 19:34 ` Kent Overstreet
2018-05-30 19:36 ` Jens Axboe
2018-05-30 19:37 ` Mike Snitzer
2018-05-30 19:38 ` Jens Axboe
2018-05-21 17:37 ` Kent Overstreet
2018-05-21 18:24 ` Mike Snitzer
2018-05-21 23:38 ` Kent Overstreet
2018-05-22 6:41 ` Christoph Hellwig
2018-05-22 19:09 ` Mike Snitzer
2018-05-21 15:12 ` David Sterba
2018-05-21 15:18 ` Jens Axboe
2018-05-21 14:20 ` Jens Axboe
2018-05-30 22:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530192747.GA6568@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=bacik@fb.com \
--cc=clm@fb.com \
--cc=colyli@suse.de \
--cc=darrick.wong@oracle.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).