linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang YanQing <udknight@gmail.com>
To: axboe@kernel.dk, gregkh@linuxfoundation.org,
	pombredanne@nexb.com, tglx@linutronix.de,
	caizhiyong@hisilicon.com, rdunlap@infradead.org,
	jiangheng@hisilicon.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] block: add verifier for cmdline partition
Date: Tue, 5 Jun 2018 17:38:40 +0800	[thread overview]
Message-ID: <20180605093840.GA9488@udknight> (raw)
In-Reply-To: <20180510030637.GA25734@udknight>

On Thu, May 10, 2018 at 11:06:37AM +0800, Wang YanQing wrote:
> I meet strange filesystem corruption issue recently, the reason
> is there are overlaps partitions in cmdline partition argument.
> 
> This patch add verifier for cmdline partition, then if there are
> overlaps partitions, cmdline_partition will log a warning. We don't
> treat overlaps partition as a error:
> "
> Caizhiyong <caizhiyong@hisilicon.com> said:
> Partition overlap was intentionally designed in this cmdline partition.
> reference http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html
> "
> 
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
>  Changes
>  v4-v5:
>  1:Delete unnecessary blank line at begin and end of logs.
>  2:Delete newline character in log, pr_* will add newline
>    automatically.
> 
>  v3-v4:
>  1:Fix grammar typo, reported by Randy Dunlap.
>  2:Delete unnecessary type casting, reported by Caizhiyong.
>  3:Record the reason why we can't treat overlapping partitions
>    as errors into changelog.
> 
>  v2-v3:
>  1:Fix log one pair of overlaps partitions twice in cmdline_parts_verifier.
>  2:Fix out of bound access in cmdline_parts_verifier.
> 
>  v1-v2:
>  1:Don't treat overlaps partition as a error, but log a warning.
> 
>  Hi! Jens Axboe
> 
>  What is your suggestion?
Hi! All

I just want to know what is the status about this patch?

ACK or NACK is welcome.

Thanks

  reply	other threads:[~2018-06-05  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10  3:06 [PATCH v5] block: add verifier for cmdline partition Wang YanQing
2018-06-05  9:38 ` Wang YanQing [this message]
2018-06-05 10:54   ` Caizhiyong
2018-06-05 15:21 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605093840.GA9488@udknight \
    --to=udknight@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=caizhiyong@hisilicon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiangheng@hisilicon.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).