From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Coly Li <colyli@suse.de>,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [RFC] cleanup bcache bio handling
Date: Wed, 13 Jun 2018 15:56:32 +0200 [thread overview]
Message-ID: <20180613135632.GB32418@lst.de> (raw)
In-Reply-To: <20180613110640.GA9712@ming.t460p>
On Wed, Jun 13, 2018 at 07:06:41PM +0800, Ming Lei wrote:
> > before bio_alloc_pages) that can be switched to something that just creates a
> > single bvec.
>
> Yes, multipage bvec shouldn't break any driver or fs.
It probably isn't broken, at least I didn't see assumptions of the same
number of segments. However the current poking into the bio internals as
a bad idea for a couple of reasons. First because it requires touching
bcache for any of these changes, second because it won't get merging of
pages into a single bio segment for bіos built by bch_bio_map or
bch_bio_alloc_pages, and third bcache is the last user of
bio_for_each_chunk_all in your branch, which I'd like to kill off to
keep the number of iterators down.
next prev parent reply other threads:[~2018-06-13 13:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 19:48 [RFC] cleanup bcache bio handling Christoph Hellwig
2018-06-11 19:48 ` [PATCH 1/6] block: add a bio_reuse helper Christoph Hellwig
2018-06-12 6:16 ` Kent Overstreet
2018-06-13 7:32 ` Christoph Hellwig
2018-06-13 8:54 ` Kent Overstreet
2018-06-13 13:59 ` Christoph Hellwig
2018-06-13 14:49 ` Kent Overstreet
2018-06-11 19:48 ` [PATCH 2/6] bcache: use bio_reuse instead of bio_reinit where applicable Christoph Hellwig
2018-06-11 19:48 ` [PATCH 3/6] bcache: clean up bio reuse for struct moving_io Christoph Hellwig
2018-06-11 19:48 ` [PATCH 4/6] bcache: clean up bio reuse for struct dirty_io Christoph Hellwig
2018-06-11 19:48 ` [PATCH 5/6] bcache: don't clone bio in bch_data_verify Christoph Hellwig
2018-06-11 19:48 ` [PATCH 6/6] bcache: use bio_add_page instead of open coded bio manipulation Christoph Hellwig
2018-06-12 4:40 ` [RFC] cleanup bcache bio handling Coly Li
2018-06-13 9:58 ` Kent Overstreet
2018-06-13 11:06 ` Ming Lei
2018-06-13 13:56 ` Christoph Hellwig [this message]
2018-06-13 14:54 ` Kent Overstreet
2018-06-14 1:55 ` Ming Lei
2018-06-14 7:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613135632.GB32418@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox