From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.com>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: why does __split_and_process_bio use bio_clone_bioset?
Date: Thu, 14 Jun 2018 01:19:47 -0700 [thread overview]
Message-ID: <20180614081947.GA23375@infradead.org> (raw)
Hi Neil,
In commit 18a25da8 ("dm: ensure bio submission follows a depth-first
tree walk") you've added a call to bio_clone_bioset to
__split_and_process_bio. Unlike all other bio splitting code this
actually allocates a new bio_vec array instead of just splitting the bio
and the iterator. I can't actually find a good reason for that either
in a cursory review of the code, the commit or the comments.
Do you remember why this can't just use bio_clone_fast?
next reply other threads:[~2018-06-14 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 8:19 Christoph Hellwig [this message]
2018-06-14 18:12 ` why does __split_and_process_bio use bio_clone_bioset? Mike Snitzer
2018-06-14 20:08 ` Mike Snitzer
2018-06-14 23:34 ` [dm-devel] " NeilBrown
2018-06-15 7:38 ` Christoph Hellwig
2018-06-15 18:26 ` Mike Snitzer
2018-06-16 15:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614081947.GA23375@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).