From: "hch@lst.de" <hch@lst.de>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>,
Bart Van Assche <Bart.VanAssche@wdc.com>,
"randrianasulu@gmail.com" <randrianasulu@gmail.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: kernel BUG at drivers/scsi/scsi_error.c:197! - git 4.17.0-x64-08428-g7d3bf613e99a
Date: Thu, 14 Jun 2018 10:32:52 +0200 [thread overview]
Message-ID: <20180614083252.GA18536@lst.de> (raw)
In-Reply-To: <77932f7b-08ba-7ece-3778-d7da82772057@oracle.com>
On Thu, Jun 14, 2018 at 03:49:28PM +0800, jianchao.wang wrote:
> Yes, it will work for this issue.
> But we should also clear the RQF_TIMED_OUT in __blk_mq_requeue_request and blk_mq_rq_ctx_init.
blk_mq_rq_ctx_init always clears rq_flags, so we don't need to explcitly
clear it.
__blk_mq_requeue_request probablys needs it so that we handle the
case of requeuing from the error handling indeed.
next prev parent reply other threads:[~2018-06-14 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201806091606.51078.randrianasulu@gmail.com>
[not found] ` <025bf705-15b0-65e5-4b16-6c91d41c1730@infradead.org>
2018-06-12 15:28 ` kernel BUG at drivers/scsi/scsi_error.c:197! - git 4.17.0-x64-08428-g7d3bf613e99a Bart Van Assche
2018-06-13 1:28 ` Andrew Randrianasulu
2018-06-13 4:03 ` jianchao.wang
2018-06-13 7:38 ` Andrew Randrianasulu
2018-06-13 14:04 ` hch
2018-06-13 14:08 ` Bart Van Assche
2018-06-13 14:35 ` hch
2018-06-14 7:49 ` jianchao.wang
2018-06-14 8:32 ` hch [this message]
2018-06-14 3:12 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614083252.GA18536@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randrianasulu@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).