From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756214AbeFOS0g (ORCPT ); Fri, 15 Jun 2018 14:26:36 -0400 Date: Fri, 15 Jun 2018 14:26:31 -0400 From: Mike Snitzer To: Christoph Hellwig Cc: NeilBrown , linux-block@vger.kernel.org, dm-devel@redhat.com, Ming Lei Subject: Re: why does __split_and_process_bio use bio_clone_bioset? Message-ID: <20180615182631.GA6906@redhat.com> References: <20180614081947.GA23375@infradead.org> <20180614181245.GA1161@redhat.com> <20180614200808.GA46373@redhat.com> <20180615073846.GA29726@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180615073846.GA29726@infradead.org> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Fri, Jun 15 2018 at 3:38am -0400, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 04:08:09PM -0400, Mike Snitzer wrote: > > The patch below seems to work fine (given quick testing).. It also has a > > side-effect of not breaking integrity support (which commit 18a25da8 > > appears to do because it isn't accounting for any of the integrity stuff > > bio_split, or dm.c:clone_bio, does). > > Looks sensible to me. Are you going to queue this up for 4.18? Yes. Already queued, likely won't send to Linus until end of next week though.. unless you want it upstream sooner? https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.18&id=bbb683cf88f58742233c3551d1b9839a5fe5bbf8