Linux block layer
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@gmail.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH v2] Revert "block: Add warning for bi_next not NULL in bio_endio()"
Date: Tue, 19 Jun 2018 14:16:18 -0400	[thread overview]
Message-ID: <20180619181618.GA19298@kmo-pixel> (raw)
In-Reply-To: <20180619172640.15246-1-bart.vanassche@wdc.com>

On Tue, Jun 19, 2018 at 10:26:40AM -0700, Bart Van Assche wrote:
> Commit 0ba99ca4838b ("block: Add warning for bi_next not NULL in
> bio_endio()") breaks the dm driver. end_clone_bio() detects whether
> or not a bio is the last bio associated with a request by checking
> the .bi_next field. Commit 0ba99ca4838b clears that field before
> end_clone_bio() has had a chance to inspect that field. Hence revert
> commit 0ba99ca4838b.
> 
> This patch avoids that KASAN reports the following complaint when
> running the srp-test software (srp-test/run_tests -c -d -r 10 -t 02-mq):

Thanks for debugging this

I take it if we had a test for request based dm in blktests or somewhere that
probably would have caught this much easier :/

  parent reply	other threads:[~2018-06-19 18:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 17:26 [PATCH v2] Revert "block: Add warning for bi_next not NULL in bio_endio()" Bart Van Assche
2018-06-19 17:39 ` Mike Snitzer
2018-06-19 18:00 ` Jens Axboe
2018-06-19 18:16 ` Kent Overstreet [this message]
2018-06-19 18:17   ` Bart Van Assche
2018-06-19 18:19     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180619181618.GA19298@kmo-pixel \
    --to=kent.overstreet@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox