From: Omar Sandoval <osandov@osandov.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Omar Sandoval <osandov@fb.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH blktests 13/15] src/Makefile: Fix pattern rule
Date: Mon, 25 Jun 2018 15:54:47 -0700 [thread overview]
Message-ID: <20180625225447.GD1218@vader> (raw)
In-Reply-To: <20180622221946.10987-14-bart.vanassche@wdc.com>
On Fri, Jun 22, 2018 at 03:19:44PM -0700, Bart Van Assche wrote:
> According to the GNU make documentation, the syntax for pattern rules
> is as follows:
>
> <target pattern>+: <source pattern>
> <rule>
That's because this is a static pattern rule:
https://www.gnu.org/software/make/manual/html_node/Static-Usage.html
So calling this a fix isn't accurate :) I'll fold this change into the
change adding the C++ program.
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> ---
> src/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile b/src/Makefile
> index 612282d14af8..d7ae832fc4fd 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -13,7 +13,7 @@ all: $(TARGETS)
> clean:
> rm -f $(TARGETS)
>
> -$(TARGETS): %: %.c
> +%: %.c
> $(CC) -Wall -o $@ $(CPPFLAGS) $(CFLAGS) $^
>
> .PHONY: all clean
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-06-25 22:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 22:19 [PATCH blktests 00/15] Add SRP initiator driver tests Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 01/15] common/rc: Fix _have_tracepoint() Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 02/15] Annotate include statements in shell scripts where the source file is a variable Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 03/15] check, tests/meta/012: Use array["index"] instead of array[index] Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 04/15] Suppress shellcheck complaints about global variables Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 05/15] check: Avoid that shellcheck complains that $FULL appears unused Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 06/15] Multiple tests: remove unused and undefined variables Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 07/15] Avoid passing tests/block/002 arguments to _init_scsi_debug Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 08/15] check: Suppress a shellcheck warning about the DMESG_FILTER initialization Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 09/15] Makefile: Do not suppress useful shellcheck warnings Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 10/15] tests/meta/group: Fix shellcheck complaints Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 11/15] make check: Also check tests/*/group files Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 12/15] check: Make TMPDIR absolute Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 13/15] src/Makefile: Fix pattern rule Bart Van Assche
2018-06-25 22:54 ` Omar Sandoval [this message]
2018-06-22 22:19 ` [PATCH blktests 14/15] Add the discontiguous-io test program Bart Van Assche
2018-06-22 22:19 ` [PATCH blktests 15/15] Add tests for the SRP initiator and target drivers Bart Van Assche
2018-06-26 8:57 ` Johannes Thumshirn
2018-06-26 15:25 ` Bart Van Assche
2018-06-26 21:01 ` Omar Sandoval
2018-06-23 3:14 ` [PATCH blktests 00/15] Add SRP initiator driver tests Ming Lei
2018-06-23 3:19 ` Ming Lei
2018-06-25 17:05 ` Bart Van Assche
2018-06-26 1:37 ` Ming Lei
2018-06-26 2:16 ` Bart Van Assche
2018-06-26 7:27 ` Johannes Thumshirn
2018-06-26 15:24 ` Bart Van Assche
2018-06-26 21:00 ` Omar Sandoval
2018-06-27 7:04 ` Johannes Thumshirn
2018-06-26 21:02 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625225447.GD1218@vader \
--to=osandov@osandov.com \
--cc=bart.vanassche@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).