Re: [PATCH blktests 00/15] Add SRP initiator driver tests

[Omar Sandoval <osandov@osandov.com>]

On Tue, Jun 26, 2018 at 08:24:51AM -0700, Bart Van Assche wrote:
> On 06/26/18 00:27, Johannes Thumshirn wrote:
> > On Tue, Jun 26, 2018 at 02:16:26AM +0000, Bart Van Assche wrote:
> > > On Tue, 2018-06-26 at 09:37 +0800, Ming Lei wrote:
> > > > I run SRP test on Fedora 27, and not run any LIO specific commands
> > > > to load it, seems it is done automatically.
> > > > 
> > > > So looks it might not a good idea to fail SRP test if LIO is loaded,
> > > > just wondering why your SRP test can't make the two co-exist?
> > > 
> > > The LIO configuration is system-wide. Only one configuration can be
> > > loaded at any given time. I don't think that the SRP tests should wipe
> > > any existing LIO configuration data if e.g. blktests is run accidentally
> > > on a production server. I think that wiping LIO configuration data should
> > > be a manual step.
> > 
> > I think this should be handled in requires(). I.e. check if LIO is
> > already configured and then skip the test if it is.
> 
> As far as I know the requires() function is per test and there is no such
> function at the group level. I prefer to define this test once at the group
> level instead of copy/pasting the same test thirteen times in each test.
> 
> Bart.

That's exactly what group_requires() is for, you even defined it :)