From: Mike Snitzer <snitzer@redhat.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Ming Lei <ming.lei@redhat.com>, Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
stable@vger.kernel.org
Subject: Re: block: Fix cloning of requests with a special payload
Date: Thu, 28 Jun 2018 11:33:11 -0400 [thread overview]
Message-ID: <20180628153311.GB17723@redhat.com> (raw)
In-Reply-To: <20180627195518.13958-1-bart.vanassche@wdc.com>
On Wed, Jun 27 2018 at 3:55pm -0400,
Bart Van Assche <bart.vanassche@wdc.com> wrote:
> This patch avoids that removing a path controlled by the dm-mpath driver
> while mkfs is running triggers the following kernel bug:
>
> kernel BUG at block/blk-core.c:3347!
> invalid opcode: 0000 [#1] PREEMPT SMP KASAN
> CPU: 20 PID: 24369 Comm: mkfs.ext4 Not tainted 4.18.0-rc1-dbg+ #2
> RIP: 0010:blk_end_request_all+0x68/0x70
> Call Trace:
> <IRQ>
> dm_softirq_done+0x326/0x3d0 [dm_mod]
> blk_done_softirq+0x19b/0x1e0
> __do_softirq+0x128/0x60d
> irq_exit+0x100/0x110
> smp_call_function_single_interrupt+0x90/0x330
> call_function_single_interrupt+0xf/0x20
> </IRQ>
>
> Fixes: f9d03f96b988 ("block: improve handling of the magic discard payload")
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Mike Snitzer <snitzer@redhat.com>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: Johannes Thumshirn <jthumshirn@suse.de>
> Cc: <stable@vger.kernel.org>
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2018-06-28 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 19:55 [PATCH] block: Fix cloning of requests with a special payload Bart Van Assche
2018-06-27 23:41 ` Ming Lei
2018-06-27 23:43 ` Bart Van Assche
2018-06-28 14:31 ` Christoph Hellwig
2018-06-28 15:33 ` Mike Snitzer [this message]
2018-06-28 15:51 ` Jens Axboe
2018-06-28 16:17 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628153311.GB17723@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).