Re: [PATCH V2 1/3] blk-mq: use list_splice_tail_init() to insert requests

Christoph Hellwig
2018-06-29T08:34:48Z

On Fri, Jun 29, 2018 at 04:12:50PM +0800, Ming Lei wrote:
> list_splice_tail_init() is much more faster than inserting each
> request one by one, given all requets in 'list' belong to
> same sw queue and ctx->lock is required to insert requests.

Looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

We should still make the trace loop conditional, but than can be a
separate patch.