From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ming Lei <ming.lei@redhat.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block <linux-block@vger.kernel.org>,
Douglas Gilbert <dgilbert@interlog.com>,
Bart Van Assche <bart.vanassche@wdc.com>,
Jens Axboe <axboe@kernel.dk>, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH] scsi: scsi_debug: introduce module parameter of 'use_blk_mq'
Date: Mon, 2 Jul 2018 06:41:35 -0700 [thread overview]
Message-ID: <20180702134134.GA15401@infradead.org> (raw)
In-Reply-To: <CACVXFVPn5VJraoidihjA5_hzuRBU_JBJAtRsNr_x9Cc3iWwaAw@mail.gmail.com>
On Mon, Jul 02, 2018 at 09:13:35PM +0800, Ming Lei wrote:
> On Mon, Jul 2, 2018 at 8:54 PM, Christoph Hellwig <hch@infradead.org> wrote:
> > On Mon, Jul 02, 2018 at 01:06:42PM +0800, Ming Lei wrote:
> >> With the introduced module parameter of 'use_blk_mq', it is easy
> >> to switch between 'blk_mq' and 'non_blk_mq' by reloading scsi_debug
> >> module, so that we can test scsi_mq/blk_mq related regressions easily.
> >
> > No. We should not make a per driver choice.
>
> Could you share us why we can't?
Because it really is not a driver propery what code we use, it
is one of the core scsi code. And intended as a temporary one,
although it already has lasted far too long.
next prev parent reply other threads:[~2018-07-02 13:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 5:06 [PATCH] scsi: scsi_debug: introduce module parameter of 'use_blk_mq' Ming Lei
2018-07-02 12:54 ` Christoph Hellwig
2018-07-02 12:56 ` Johannes Thumshirn
2018-07-02 13:03 ` Christoph Hellwig
2018-07-02 13:08 ` Johannes Thumshirn
2018-07-02 13:16 ` Ming Lei
2018-07-03 6:58 ` Hannes Reinecke
2018-07-02 13:13 ` Ming Lei
2018-07-02 13:41 ` Christoph Hellwig [this message]
2018-07-02 20:28 ` Douglas Gilbert
2018-07-02 20:37 ` Jens Axboe
2018-07-02 23:43 ` Ming Lei
2018-07-03 14:05 ` Jens Axboe
2018-07-03 15:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702134134.GA15401@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=dgilbert@interlog.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).