From: Omar Sandoval <osandov@osandov.com>
To: Evan Green <evgreen@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Sam Hurst <shurst@google.com>
Subject: Re: [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl
Date: Mon, 2 Jul 2018 16:43:07 -0700 [thread overview]
Message-ID: <20180702234307.GA27810@vader> (raw)
In-Reply-To: <20180702230346.72350-1-evgreen@chromium.org>
On Mon, Jul 02, 2018 at 04:03:46PM -0700, Evan Green wrote:
> This change adds LOOP_SET_BLOCK_SIZE as one of the supported ioctls
> in lo_compat_ioctl. It only takes an unsigned long argument, and
> in practice a 32-bit value works fine.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Evan Green <evgreen@chromium.org>
> ---
> drivers/block/loop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index d6b6f434fd4b..4cb1d1be3cfb 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1613,6 +1613,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode,
> arg = (unsigned long) compat_ptr(arg);
> case LOOP_SET_FD:
> case LOOP_CHANGE_FD:
> + case LOOP_SET_BLOCK_SIZE:
> err = lo_ioctl(bdev, mode, cmd, arg);
> break;
> default:
> --
> 2.16.4
>
next prev parent reply other threads:[~2018-07-02 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 23:03 [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl Evan Green
2018-07-02 23:43 ` Omar Sandoval [this message]
2018-07-03 13:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702234307.GA27810@vader \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=evgreen@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shurst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).