* [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl
@ 2018-07-02 23:03 Evan Green
2018-07-02 23:43 ` Omar Sandoval
2018-07-03 13:52 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Evan Green @ 2018-07-02 23:03 UTC (permalink / raw)
To: Jens Axboe, linux-block, linux-kernel; +Cc: Sam Hurst, Evan Green
This change adds LOOP_SET_BLOCK_SIZE as one of the supported ioctls
in lo_compat_ioctl. It only takes an unsigned long argument, and
in practice a 32-bit value works fine.
Signed-off-by: Evan Green <evgreen@chromium.org>
---
drivers/block/loop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index d6b6f434fd4b..4cb1d1be3cfb 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1613,6 +1613,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode,
arg = (unsigned long) compat_ptr(arg);
case LOOP_SET_FD:
case LOOP_CHANGE_FD:
+ case LOOP_SET_BLOCK_SIZE:
err = lo_ioctl(bdev, mode, cmd, arg);
break;
default:
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl
2018-07-02 23:03 [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl Evan Green
@ 2018-07-02 23:43 ` Omar Sandoval
2018-07-03 13:52 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Omar Sandoval @ 2018-07-02 23:43 UTC (permalink / raw)
To: Evan Green; +Cc: Jens Axboe, linux-block, linux-kernel, Sam Hurst
On Mon, Jul 02, 2018 at 04:03:46PM -0700, Evan Green wrote:
> This change adds LOOP_SET_BLOCK_SIZE as one of the supported ioctls
> in lo_compat_ioctl. It only takes an unsigned long argument, and
> in practice a 32-bit value works fine.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Evan Green <evgreen@chromium.org>
> ---
> drivers/block/loop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index d6b6f434fd4b..4cb1d1be3cfb 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1613,6 +1613,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode,
> arg = (unsigned long) compat_ptr(arg);
> case LOOP_SET_FD:
> case LOOP_CHANGE_FD:
> + case LOOP_SET_BLOCK_SIZE:
> err = lo_ioctl(bdev, mode, cmd, arg);
> break;
> default:
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl
2018-07-02 23:03 [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl Evan Green
2018-07-02 23:43 ` Omar Sandoval
@ 2018-07-03 13:52 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-07-03 13:52 UTC (permalink / raw)
To: Evan Green, linux-block, linux-kernel; +Cc: Sam Hurst
On 7/2/18 5:03 PM, Evan Green wrote:
> This change adds LOOP_SET_BLOCK_SIZE as one of the supported ioctls
> in lo_compat_ioctl. It only takes an unsigned long argument, and
> in practice a 32-bit value works fine.
Applied for 4.18, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-03 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02 23:03 [PATCH] loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl Evan Green
2018-07-02 23:43 ` Omar Sandoval
2018-07-03 13:52 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).