From: Josef Bacik <josef@toxicpanda.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] blk-iolatency: fix max_depth comparisons
Date: Wed, 11 Jul 2018 10:28:58 -0400 [thread overview]
Message-ID: <20180711142857.tesdgn7kukmyrepi@destiny> (raw)
In-Reply-To: <7dc883e2-7bb0-f837-9547-619b5e51f81d@kernel.dk>
On Wed, Jul 11, 2018 at 08:22:28AM -0600, Jens Axboe wrote:
> On 7/11/18 7:30 AM, Josef Bacik wrote:
> > max_depth used to be a u64, but I changed it to a unsigned int but
> > didn't convert my comparisons over everywhere. Fix by comparing to
> > INT_MAX instead of (u64)-1.
>
> Should that be UINT_MAX?
>
Hmm I suppose it should, though I'm really just using it to indicate that we're
unthrottled so it doesn't matter a whole lot. Would you prefer I just switch it
all over to UINT_MAX? Thanks,
Josef
next prev parent reply other threads:[~2018-07-11 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 13:30 [PATCH] blk-iolatency: fix max_depth comparisons Josef Bacik
2018-07-11 14:22 ` Jens Axboe
2018-07-11 14:28 ` Josef Bacik [this message]
2018-07-11 14:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711142857.tesdgn7kukmyrepi@destiny \
--to=josef@toxicpanda.com \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox