linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@linux.intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@kernel.dk>,
	linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org,
	linux-block@vger.kernel.org,
	Jianchao Wang <jianchao.w.wang@oracle.com>,
	Bart Van Assche <bart.vanassche@wdc.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] scsi: set timed out out mq requests to complete
Date: Fri, 20 Jul 2018 08:05:27 -0600	[thread overview]
Message-ID: <20180720140527.GA4093@localhost.localdomain> (raw)
In-Reply-To: <20180720065258.cucvur7n5tugl75u@linux-x5ow.site>

On Fri, Jul 20, 2018 at 08:52:58AM +0200, Johannes Thumshirn wrote:
> On Thu, Jul 19, 2018 at 03:26:18PM -0600, Keith Busch wrote:
> > The scsi block layer requires requests claimed be the error handling be
> > completed by the error handler. A previous commit allowed completions
> > to proceed for blk-mq, breaking that assumption.
> 
> Ahm the first sentence is a bit hard to parse, sorry.
> Did you mean something like:
> 
> "The scsi block later requires requests claimed by the error handling
> to be completed by the error handler"?

Ugh, sorry. Yes, you are correct on the intended phrasing.

  reply	other threads:[~2018-07-20 14:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 21:26 [PATCH 1/2] blk-mq: export setting request completion state Keith Busch
2018-07-19 21:26 ` [PATCH 2/2] scsi: set timed out out mq requests to complete Keith Busch
2018-07-20  6:52   ` Johannes Thumshirn
2018-07-20 14:05     ` Keith Busch [this message]
2018-07-20 14:41   ` Christoph Hellwig
2018-07-20 14:50     ` Keith Busch
2018-07-20 15:12   ` Bart Van Assche
2018-07-20 15:56     ` Keith Busch
2018-07-20 16:03       ` Bart Van Assche
2018-07-20 16:12         ` Keith Busch
2018-07-20 16:20           ` Bart Van Assche
2018-07-20 16:23             ` Keith Busch
2018-07-20 16:45               ` Bart Van Assche
2018-07-20 17:24                 ` Keith Busch
2018-07-23  8:12                   ` hch
2018-07-23 13:59                     ` Bart Van Assche
2018-07-23 14:04                     ` Keith Busch
2018-07-23  8:09 ` [PATCH 1/2] blk-mq: export setting request completion state Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720140527.GA4093@localhost.localdomain \
    --to=keith.busch@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=hch@lst.de \
    --cc=jianchao.w.wang@oracle.com \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).