From: Keith Busch <keith.busch@linux.intel.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>,
"hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH 2/2] scsi: set timed out out mq requests to complete
Date: Fri, 20 Jul 2018 10:12:41 -0600 [thread overview]
Message-ID: <20180720161240.GF4093@localhost.localdomain> (raw)
In-Reply-To: <2b01f0a8d5864b2563573d46ce5b4ec5f593f538.camel@wdc.com>
On Fri, Jul 20, 2018 at 04:03:18PM +0000, Bart Van Assche wrote:
> On Fri, 2018-07-20 at 09:56 -0600, Keith Busch wrote:
> > SCSI is the only block driver that wants this behavior. Moving it back
> > to generic where it used to be breaks other block drivers.
>
> That's new to me. What would break in the NVMe driver if the above change would be
> present in the block layer?
This is what causes the block layer to lose completions, and most drivers
don't want the kernel to lose their completions.
next prev parent reply other threads:[~2018-07-20 16:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 21:26 [PATCH 1/2] blk-mq: export setting request completion state Keith Busch
2018-07-19 21:26 ` [PATCH 2/2] scsi: set timed out out mq requests to complete Keith Busch
2018-07-20 6:52 ` Johannes Thumshirn
2018-07-20 14:05 ` Keith Busch
2018-07-20 14:41 ` Christoph Hellwig
2018-07-20 14:50 ` Keith Busch
2018-07-20 15:12 ` Bart Van Assche
2018-07-20 15:56 ` Keith Busch
2018-07-20 16:03 ` Bart Van Assche
2018-07-20 16:12 ` Keith Busch [this message]
2018-07-20 16:20 ` Bart Van Assche
2018-07-20 16:23 ` Keith Busch
2018-07-20 16:45 ` Bart Van Assche
2018-07-20 17:24 ` Keith Busch
2018-07-23 8:12 ` hch
2018-07-23 13:59 ` Bart Van Assche
2018-07-23 14:04 ` Keith Busch
2018-07-23 8:09 ` [PATCH 1/2] blk-mq: export setting request completion state Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720161240.GF4093@localhost.localdomain \
--to=keith.busch@linux.intel.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).