From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: keith.busch@intel.com, linux-nvme@lists.infradead.org,
sagi@grimberg.me, hch@lst.de, martin.petersen@oracle.com,
linux-block@vger.kernel.org, axboe@kernel.dk,
vladimirk@mellanox.com
Subject: Re: [PATCH 1/3] block: move ref_tag calculation func to the block layer
Date: Tue, 24 Jul 2018 15:52:57 +0200 [thread overview]
Message-ID: <20180724135257.GA29918@lst.de> (raw)
In-Reply-To: <1532439222-5668-1-git-send-email-maxg@mellanox.com>
> case NVME_NS_DPS_PI_TYPE2:
> control |= NVME_RW_PRINFO_PRCHK_GUARD |
> NVME_RW_PRINFO_PRCHK_REF;
> - cmnd->rw.reftag = cpu_to_le32(
> - nvme_block_nr(ns, blk_rq_pos(req)));
> + cmnd->rw.reftag = cpu_to_le32(t10_pi_ref_tag(req));
Note that this changes behavior for non-512 byte block sizes. But
I think these changes do the right thing..
prev parent reply other threads:[~2018-07-24 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 13:33 [PATCH 1/3] block: move ref_tag calculation func to the block layer Max Gurtovoy
2018-07-24 13:33 ` [PATCH 2/3] block: move dif_prepare/dif_complete functions to " Max Gurtovoy
2018-07-24 13:55 ` Christoph Hellwig
2018-07-24 14:33 ` Max Gurtovoy
2018-07-24 17:41 ` Christoph Hellwig
2018-07-24 20:33 ` Keith Busch
2018-07-24 22:32 ` Max Gurtovoy
2018-07-24 13:33 ` [PATCH 3/3] nvme: use blk API to remap ref tags for IOs with metadata Max Gurtovoy
2018-07-24 13:56 ` Christoph Hellwig
2018-07-24 13:52 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724135257.GA29918@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).