From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Martin Wilck <martin.wilck@suse.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 0/5] genhd: implement device_add_disk_with_groups()
Date: Wed, 25 Jul 2018 08:28:35 +0200 [thread overview]
Message-ID: <20180725062840.94114-1-hare@suse.de> (raw)
When creating a block device some drivers need to create additional sysfs
groups to store driver-specific informations.
With the current workflow of adding these groups with a separate call to
sysfs after the device has been created we are introducing a race with udev,
as the uevent is generated before the sysfs attributes are created, and udev
fails to read the required information.
This patchset adds a new function 'device_add_disk_with_groups()' and converts
the obvious candidates to use this new function.
As usual, comments and reviews are welcome.
Hannes Reinecke (5):
genhd: drop 'bool' argument from __device_add_disk()
block: genhd: add device_add_disk_with_groups
nvme: register ns_id attributes as default sysfs groups
aoe: use device_add_disk_with_groups()
zram: use device_add_disk_with_groups()
block/genhd.c | 38 ++++++++++++++++++++++++++++++--------
drivers/block/aoe/aoe.h | 1 -
drivers/block/aoe/aoeblk.c | 21 +++++++--------------
drivers/block/aoe/aoedev.c | 1 -
drivers/block/zram/zram_drv.c | 28 +++++++---------------------
drivers/nvme/host/core.c | 14 +++++++-------
drivers/nvme/host/multipath.c | 12 +++---------
drivers/nvme/host/nvme.h | 2 +-
include/linux/genhd.h | 3 +++
9 files changed, 58 insertions(+), 62 deletions(-)
--
2.12.3
next reply other threads:[~2018-07-25 6:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 6:28 Hannes Reinecke [this message]
2018-07-25 6:28 ` [PATCH 1/5] genhd: drop 'bool' argument from __device_add_disk() Hannes Reinecke
2018-07-25 7:45 ` Christoph Hellwig
2018-07-25 6:28 ` [PATCH 2/5] block: genhd: add device_add_disk_with_groups Hannes Reinecke
2018-07-25 7:46 ` Christoph Hellwig
2018-07-25 8:27 ` Martin Wilck
2018-07-25 6:28 ` [PATCH 3/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-07-25 6:28 ` [PATCH 4/5] aoe: use device_add_disk_with_groups() Hannes Reinecke
2018-07-25 6:28 ` [PATCH 5/5] zram: " Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725062840.94114-1-hare@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.wilck@suse.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox