From: Josef Bacik <josef@toxicpanda.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] block: don't do cgroup accounting for split bio's
Date: Fri, 27 Jul 2018 17:19:14 -0400 [thread overview]
Message-ID: <20180727211913.47f3pssntdidjfdc@destiny> (raw)
In-Reply-To: <838a33f4-90e4-f939-f0e4-4434122e7f2e@kernel.dk>
On Fri, Jul 27, 2018 at 03:17:11PM -0600, Jens Axboe wrote:
> On 7/27/18 3:14 PM, Josef Bacik wrote:
> > We need to check in blkcg_bio_issue_check if the bio is flagged as
> > QUEUE_ENTERED, because if it is then we've already accounted for the IO
> > in the cgroup stats.
>
> That's a bit of a flag overload, I think that at least warrants a
> comment.
Yeah I'm not a fan of it, but there's nothing else to indicate that the bio is a
split bio other than checking if it's endio is the chain endio. I'll respin
with the comment. Thanks,
Josef
prev parent reply other threads:[~2018-07-27 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 21:14 [PATCH] block: don't do cgroup accounting for split bio's Josef Bacik
2018-07-27 21:17 ` Jens Axboe
2018-07-27 21:19 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727211913.47f3pssntdidjfdc@destiny \
--to=josef@toxicpanda.com \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox