From: Ming Lei <ming.lei@redhat.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: Omar Sandoval <osandov@fb.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block/023: performance test on queue creation & cleanup
Date: Mon, 30 Jul 2018 06:43:24 +0800 [thread overview]
Message-ID: <20180729224322.GB30770@ming.t460p> (raw)
In-Reply-To: <20180725213314.GD16847@vader>
On Wed, Jul 25, 2018 at 02:33:14PM -0700, Omar Sandoval wrote:
> On Wed, Jul 04, 2018 at 01:29:56PM +0800, Ming Lei wrote:
> > SCSI may have lots of channels, targets or LUNs, so it may
> > take long time for creating and cleaning up queues.
> >
> > So introduce block/023 and uses null_blk to run this test
> > on both blk-mq and legacy mode, then compare both and check
> > the difference.
> >
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> > ---
> > tests/block/023 | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> > tests/block/023.out | 2 ++
> > 2 files changed, 103 insertions(+)
> > create mode 100755 tests/block/023
> > create mode 100755 tests/block/023.out
>
> Hi, Ming, is this a regression test for "blk-mq: remove
> synchronize_rcu() from blk_mq_del_queue_tag_set()" and "blk-mq: avoid to
> synchronize rcu inside blk_cleanup_queue()"?
Yeah, it is.
It also shows that destroying queue may take much more time than
creating queue, and seems no solution for this one now.
Thanks,
Ming
prev parent reply other threads:[~2018-07-29 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 5:29 [PATCH] block/023: performance test on queue creation & cleanup Ming Lei
2018-07-25 21:33 ` Omar Sandoval
2018-07-29 22:43 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180729224322.GB30770@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox