Re: [PATCH 4/6] aoe: use device_add_disk_with_groups()

Ed Cashin
2018-08-01T01:00:28Z

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

On Mon, Jul 30, 2018 at 3:12 AM Hannes Reinecke <hare@suse.de> wrote:

> Use device_add_disk_with_groups() to avoid a race condition with
> udev during startup.
>

I love the idea of getting rid of the race, but I am having trouble
seeing what happened to the cleanup we had via sysfs_remove_group.
You're storing a pointer to groups off the device, but I don't see it
getting
used for cleanup later in this patch set. Are you patching linux-next?

-- Ed

[-- Attachment #2: Type: text/html, Size: 788 bytes --]