From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Jul 2018 13:12:25 -0700 From: "hch@infradead.org" To: Bart Van Assche Cc: "keescook@chromium.org" , "axboe@kernel.dk" , "vinod.koul@intel.com" , "david.kershner@unisys.com" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "rdunlap@infradead.org" , "u.kleine-koenig@pengutronix.de" , "nab@linux-iscsi.org" , "tglx@linutronix.de" , "hch@lst.de" , "martin.petersen@oracle.com" , "manoj@linux.vnet.ibm.com" , "sdharia@codeaurora.org" , "jgross@suse.com" , "cyrille.pitchen@free-electrons.com" , "linux-ide@vger.kernel.org" , "viresh.kumar@linaro.org" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , "pombredanne@nexb.com" , "bp@alien8.de" , "mrochs@linux.vnet.ibm.com" , "tj@kernel.org" , "jejb@linux.vnet.ibm.com" , "davem@davemloft.net" , "sboyd@codeaurora.org" , "linux-kernel@vger.kernel.org" , "ukrishn@linux.vnet.ibm.com" Subject: Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users Message-ID: <20180731201225.GA1989@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Tue, Jul 31, 2018 at 08:01:16PM +0000, Bart Van Assche wrote: > On Tue, 2018-07-31 at 12:51 -0700, Kees Cook wrote: > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 24cd47014657..a6abd7a856c6 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -76,7 +76,7 @@ obj-$(CONFIG_DMA_SHARED_BUFFER) += dma-buf/ > > obj-$(CONFIG_NUBUS) += nubus/ > > obj-y += macintosh/ > > obj-$(CONFIG_IDE) += ide/ > > -obj-$(CONFIG_SCSI) += scsi/ > > +obj-y += scsi/ > > obj-y += nvme/ > > obj-$(CONFIG_ATA) += ata/ > > obj-$(CONFIG_TARGET_CORE) += target/ > > The above change not only selects scsi_common.o but also the following object > files: scsi.o hosts.o scsi_ioctl.o scsicam.o scsi_error.o scsi_lib.o scsi_scan.o > scsi_sysfs.o scsi_devinfo.o scsi_trace.o scsi_logging.o. That is a change that > has not been mentioned in the patch description. It shouldn't. All these are built into scsi_mod.o, which is only built when CONFIG_SCSI is set. Under what circumstances do you see them built?