From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 1 Aug 2018 01:24:07 -0700 From: Christoph Hellwig To: Kees Cook Cc: Jens Axboe , Christoph Hellwig , "Martin K. Petersen" , "James E.J. Bottomley" , Tejun Heo , Borislav Petkov , "David S. Miller" , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "Nicholas A. Bellinger" , Thomas Gleixner , Philippe Ombredanne , Stephen Boyd , Cyrille Pitchen , Juergen Gross , Viresh Kumar , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Sagar Dharia , Randy Dunlap , Vinod Koul , David Kershner , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/9] cdrom: Use struct scsi_sense_hdr internally Message-ID: <20180801082407.GC26378@infradead.org> References: <20180731195155.46664-1-keescook@chromium.org> <20180731195155.46664-8-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180731195155.46664-8-keescook@chromium.org> List-ID: On Tue, Jul 31, 2018 at 12:51:52PM -0700, Kees Cook wrote: > This removes more casts of struct request_sense and uses the standard > struct scsi_sense_hdr instead. This also fixes any possible stale values > since the prior code did not check the sense length. > > Signed-off-by: Kees Cook Looks good, Reviewed-by: Christoph Hellwig