From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 5 Sep 2018 15:19:15 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Kent Overstreet , Dmitry Monakhov , Christoph Hellwig , Hannes Reinecke Subject: Re: [PATCH] block: remove bio_rewind_iter() Message-ID: <20180905131915.GB26956@lst.de> References: <20180905033335.12666-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180905033335.12666-1-ming.lei@redhat.com> List-ID: > + bio->bi_status = bio_integrity_process(bio, &bip->bio_iter, bi->profile->verify_fn); Please split the overly long line. Otherwise this looks fine: Reviewed-by: Christoph Hellwig