Re: [PATCH 02/15] blkcg: delay blkg destruction until after writeback has finished

kbuild test robot
2018-08-31T11:09:55Z

[-- Attachment #1: Type: text/plain, Size: 1746 bytes --]

Hi Dennis,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on block/for-next]
[also build test ERROR on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Dennis-Zhou/blkcg-ref-count-refactor-cleanup-blkcg-avg_lat/20180831-161742
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-randconfig-x015-201834 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

In file included from kernel/trace/blktrace.c:18:0:
include/linux/blk-cgroup.h: In function 'blkcg_cgwb_inc':
>> include/linux/blk-cgroup.h:398:19: error: 'struct blkcg' has no member named 'nr_cgwbs'
atomic_inc(&blkcg->nr_cgwbs);
^~
include/linux/blk-cgroup.h: In function 'blkcg_cgwb_dec':
include/linux/blk-cgroup.h:414:32: error: 'struct blkcg' has no member named 'nr_cgwbs'
if (atomic_dec_and_test(&blkcg->nr_cgwbs))
^~

vim +398 include/linux/blk-cgroup.h

389
390 /**
391 * blkcg_cgwb_inc - increment the count for cgwb_list
392 * @blkcg: blkcg of interest
393 *
394 * This is used to count the number of active wb's related to a blkcg.
395 */
396 static inline void blkcg_cgwb_inc(struct blkcg *blkcg)
397 {
> 398 atomic_inc(&blkcg->nr_cgwbs);
399 }
400

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28303 bytes --]