From: Ming Lei <ming.lei@redhat.com>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH V3 00/17] SCSI: introduce per-host admin queue & enable runtime PM
Date: Tue, 18 Sep 2018 15:42:47 +0800 [thread overview]
Message-ID: <20180918074245.GC4805@ming.t460p> (raw)
In-Reply-To: <0475ffa4-be81-e35f-efe8-6821bada104c@oracle.com>
On Tue, Sep 18, 2018 at 09:17:12AM +0800, jianchao.wang wrote:
> Hi Ming
>
> On 09/17/2018 08:07 PM, Ming Lei wrote:
> >>> This way will delay runtime pm or system suspend until the queue is unfrozen,
> >>> but it isn't reasonable.
> >> This interface is for the __scsi_execute only, before we call into function, we should have
> >> get the device resumed synchronously.
> > I mean when the queue is frozen, it is reasonable to runtime suspend the queue. However,
> > blk_queue_preempt_enter() is still waiting for queue becoming unfreezing first.
>
> We don't freeze the queue, but set preempt-only mode when suspend the queue. :)
But the queue can be frozen by other paths. Even though it is frozen, the queue
should be allowed to suspend too.
Thanks,
Ming
next prev parent reply other threads:[~2018-09-18 7:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 12:15 [PATCH V3 00/17] SCSI: introduce per-host admin queue & enable runtime PM Ming Lei
2018-09-13 12:15 ` [PATCH V3 01/17] blk-mq: allow to pass default queue flags for creating & initializing queue Ming Lei
2018-09-13 12:15 ` [PATCH V3 02/17] blk-mq: convert BLK_MQ_F_NO_SCHED into per-queue flag Ming Lei
2018-09-13 12:15 ` [PATCH V3 03/17] block: rename QUEUE_FLAG_NO_SCHED as QUEUE_FLAG_ADMIN Ming Lei
2018-09-13 12:15 ` [PATCH V3 04/17] blk-mq: don't reserve tags for admin queue Ming Lei
2018-09-13 12:15 ` [PATCH V3 05/17] SCSI: try to retrieve request_queue via 'scsi_cmnd' if possible Ming Lei
2018-09-13 12:15 ` [PATCH V3 06/17] SCSI: pass 'scsi_device' instance from 'scsi_request' Ming Lei
2018-09-13 12:15 ` [PATCH V3 07/17] SCSI: prepare for introducing admin queue for legacy path Ming Lei
2018-09-13 12:15 ` [PATCH V3 08/17] SCSI: pass scsi_device to scsi_mq_prep_fn Ming Lei
2018-09-13 12:15 ` [PATCH V3 09/17] SCSI: don't set .queuedata in scsi_mq_alloc_queue() Ming Lei
2018-09-13 12:15 ` [PATCH V3 10/17] SCSI: deal with admin queue busy Ming Lei
2018-09-13 12:15 ` [PATCH V3 11/17] SCSI: track pending admin commands Ming Lei
2018-09-14 3:33 ` jianchao.wang
2018-09-14 11:33 ` Ming Lei
2018-09-17 2:46 ` jianchao.wang
2018-09-17 11:35 ` Ming Lei
2018-09-18 1:22 ` jianchao.wang
2018-09-18 7:39 ` Ming Lei
2018-09-18 7:51 ` jianchao.wang
2018-09-18 7:55 ` Ming Lei
2018-09-18 8:25 ` jianchao.wang
2018-09-18 12:15 ` Ming Lei
2018-09-19 3:52 ` jianchao.wang
2018-09-19 8:07 ` Ming Lei
2018-09-13 12:15 ` [PATCH V3 12/17] SCSI: create admin queue for each host Ming Lei
2018-09-13 12:15 ` [PATCH V3 13/17] SCSI: use the dedicated admin queue to send admin commands Ming Lei
2018-09-13 12:15 ` [PATCH V3 14/17] SCSI: transport_spi: resume a quiesced device Ming Lei
2018-09-13 12:15 ` [PATCH V3 15/17] SCSI: use admin queue to implement queue QUIESCE Ming Lei
2018-09-13 12:15 ` [PATCH V3 16/17] block: simplify runtime PM support Ming Lei
2018-09-13 12:15 ` [PATCH V3 17/17] block: enable runtime PM for blk-mq Ming Lei
2018-09-14 10:33 ` kbuild test robot
2018-09-15 1:13 ` kbuild test robot
2018-09-14 7:27 ` [PATCH V3 00/17] SCSI: introduce per-host admin queue & enable runtime PM jianchao.wang
2018-09-16 13:09 ` Ming Lei
2018-09-17 2:25 ` jianchao.wang
2018-09-17 12:07 ` Ming Lei
2018-09-18 1:17 ` jianchao.wang
2018-09-18 7:42 ` Ming Lei [this message]
2018-09-18 7:53 ` jianchao.wang
2018-09-17 6:34 ` Hannes Reinecke
2018-09-17 11:55 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918074245.GC4805@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).