From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Ming Lei <ming.lei@redhat.com>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Alan Stern <stern@rowland.harvard.edu>
Subject: [PATCH v8 6/8] block: Schedule runtime resume earlier
Date: Tue, 18 Sep 2018 13:59:01 -0700 [thread overview]
Message-ID: <20180918205903.15516-7-bvanassche@acm.org> (raw)
In-Reply-To: <20180918205903.15516-1-bvanassche@acm.org>
Instead of scheduling runtime resume of a request queue after a
request has been queued, schedule asynchronous resume during request
allocation. The new pm_request_resume() calls occur after
blk_queue_enter() has increased the q_usage_counter request queue
member. This change is needed for a later patch that will make request
allocation block while the queue status is not RPM_ACTIVE.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
---
block/blk-core.c | 2 ++
block/elevator.c | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index fd91e9bf2893..18b874d5c9c9 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -942,6 +942,8 @@ int blk_queue_enter(struct request_queue *q, blk_mq_req_flags_t flags)
if (success)
return 0;
+ blk_pm_request_resume(q);
+
if (flags & BLK_MQ_REQ_NOWAIT)
return -EBUSY;
diff --git a/block/elevator.c b/block/elevator.c
index 1c992bf6cfb1..e18ac68626e3 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -601,7 +601,6 @@ void __elv_add_request(struct request_queue *q, struct request *rq, int where)
trace_block_rq_insert(q, rq);
blk_pm_add_request(q, rq);
- blk_pm_request_resume(q);
rq->q = q;
--
2.18.0
next prev parent reply other threads:[~2018-09-18 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 20:58 [PATCH v8 0/8] blk-mq: Implement runtime power management Bart Van Assche
2018-09-18 20:58 ` [PATCH v8 1/8] blk-mq: Document the functions that iterate over requests Bart Van Assche
2018-09-18 20:58 ` [PATCH v8 2/8] blk-mq: Introduce blk_mq_queue_rq_iter() Bart Van Assche
2018-09-18 20:58 ` [PATCH v8 3/8] block: Move power management code into a new source file Bart Van Assche
2018-09-18 20:58 ` [PATCH v8 4/8] block, scsi: Change the preempt-only flag into a counter Bart Van Assche
2018-09-18 20:59 ` [PATCH v8 5/8] block: Split blk_pm_add_request() and blk_pm_put_request() Bart Van Assche
2018-09-18 20:59 ` Bart Van Assche [this message]
2018-09-19 4:05 ` [PATCH v8 6/8] block: Schedule runtime resume earlier Ming Lei
2018-09-19 21:39 ` Bart Van Assche
2018-09-20 1:38 ` Ming Lei
2018-09-18 20:59 ` [PATCH v8 7/8] block: Make blk_get_request() block for non-PM requests while suspended Bart Van Assche
2018-09-18 20:59 ` [PATCH v8 8/8] blk-mq: Enable support for runtime power management Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918205903.15516-7-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).